milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
31.03k stars 2.95k forks source link

enhance: refine the datacoord meta related interfaces #37957

Closed tinswzy closed 3 days ago

tinswzy commented 6 days ago

issue: #35917 This PR refines the meta-related APIs in datacoord to allow the ctx to be passed down to the catalog operation interfaces

mergify[bot] commented 6 days ago

@tinswzy

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:

    • feat: for introducing a new feature.
    • fix: for bug fixes.
    • enhance: for improvements to existing functionality.
    • test: for add tests to existing functionality.
    • doc: for modifying documentation.
    • auto: for the pull request from bot.
  2. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

mergify[bot] commented 6 days ago

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 89.96540% with 29 lines in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base (74752f2) to head (76fab9a). Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/index_service.go 75.00% 0 Missing and 5 partials :warning:
internal/datacoord/services.go 85.29% 2 Missing and 3 partials :warning:
internal/datacoord/compaction.go 60.00% 4 Missing :warning:
internal/datacoord/import_scheduler.go 82.35% 3 Missing :warning:
internal/datacoord/compaction_task_meta.go 50.00% 0 Missing and 2 partials :warning:
internal/datacoord/garbage_collector.go 71.42% 0 Missing and 2 partials :warning:
internal/datacoord/meta.go 95.83% 0 Missing and 2 partials :warning:
internal/datacoord/segment_manager.go 88.23% 0 Missing and 2 partials :warning:
internal/datacoord/import_meta.go 96.00% 1 Missing :warning:
internal/datacoord/partition_stats_meta.go 50.00% 0 Missing and 1 partial :warning:
... and 2 more
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37957/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #37957 +/- ## =========================================== + Coverage 68.87% 81.02% +12.14% =========================================== Files 289 1358 +1069 Lines 25481 190556 +165075 =========================================== + Hits 17551 154404 +136853 - Misses 7930 30662 +22732 - Partials 0 5490 +5490 ``` | [Components](https://app.codecov.io/gh/milvus-io/milvus/pull/37957/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [Client](https://app.codecov.io/gh/milvus-io/milvus/pull/37957/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `72.16% <ø> (∅)` | | | [Core](https://app.codecov.io/gh/milvus-io/milvus/pull/37957/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `68.87% <ø> (ø)` | | | [Go](https://app.codecov.io/gh/milvus-io/milvus/pull/37957/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `83.19% <89.96%> (∅)` | | | [Files with missing lines](https://app.codecov.io/gh/milvus-io/milvus/pull/37957?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/datacoord/analyze\_meta.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37957?src=pr&el=tree&filepath=internal%2Fdatacoord%2Fanalyze_meta.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGF0YWNvb3JkL2FuYWx5emVfbWV0YS5nbw==) | `100.00% <100.00%> (ø)` | | | [internal/datacoord/compaction\_policy\_clustering.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37957?src=pr&el=tree&filepath=internal%2Fdatacoord%2Fcompaction_policy_clustering.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGF0YWNvb3JkL2NvbXBhY3Rpb25fcG9saWN5X2NsdXN0ZXJpbmcuZ28=) | `75.59% <100.00%> (ø)` | | | [internal/datacoord/compaction\_task\_clustering.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37957?src=pr&el=tree&filepath=internal%2Fdatacoord%2Fcompaction_task_clustering.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGF0YWNvb3JkL2NvbXBhY3Rpb25fdGFza19jbHVzdGVyaW5nLmdv) | `77.42% <100.00%> (ø)` | | | [internal/datacoord/compaction\_task\_l0.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37957?src=pr&el=tree&filepath=internal%2Fdatacoord%2Fcompaction_task_l0.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGF0YWNvb3JkL2NvbXBhY3Rpb25fdGFza19sMC5nbw==) | `93.72% <100.00%> (ø)` | | | [internal/datacoord/compaction\_task\_mix.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37957?src=pr&el=tree&filepath=internal%2Fdatacoord%2Fcompaction_task_mix.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGF0YWNvb3JkL2NvbXBhY3Rpb25fdGFza19taXguZ28=) | `61.66% <100.00%> (ø)` | | | [internal/datacoord/compaction\_trigger.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37957?src=pr&el=tree&filepath=internal%2Fdatacoord%2Fcompaction_trigger.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGF0YWNvb3JkL2NvbXBhY3Rpb25fdHJpZ2dlci5nbw==) | `85.13% <100.00%> (ø)` | | | [internal/datacoord/handler.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37957?src=pr&el=tree&filepath=internal%2Fdatacoord%2Fhandler.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGF0YWNvb3JkL2hhbmRsZXIuZ28=) | `75.30% <100.00%> (ø)` | | | [internal/datacoord/import\_checker.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37957?src=pr&el=tree&filepath=internal%2Fdatacoord%2Fimport_checker.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGF0YWNvb3JkL2ltcG9ydF9jaGVja2VyLmdv) | `84.51% <100.00%> (ø)` | | | [internal/datacoord/import\_util.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37957?src=pr&el=tree&filepath=internal%2Fdatacoord%2Fimport_util.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGF0YWNvb3JkL2ltcG9ydF91dGlsLmdv) | `86.51% <100.00%> (ø)` | | | [internal/datacoord/index\_meta.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37957?src=pr&el=tree&filepath=internal%2Fdatacoord%2Findex_meta.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGF0YWNvb3JkL2luZGV4X21ldGEuZ28=) | `95.31% <100.00%> (ø)` | | | ... and [18 more](https://app.codecov.io/gh/milvus-io/milvus/pull/37957?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | | ... and [1041 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/37957/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
congqixia commented 6 days ago

/run-cpu-e2e

jaime0815 commented 3 days ago

/lgtm

sre-ci-robot commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: tinswzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/milvus-io/milvus/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment