milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
31.03k stars 2.95k forks source link

enhance: make all index operation async scheduled by tokio #37958

Closed chyezh closed 4 days ago

chyezh commented 6 days ago

issue: #37851 related pr: https://github.com/milvus-io/tantivy/pull/3 pr: #37946

mergify[bot] commented 6 days ago

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.87%. Comparing base (16bb529) to head (b22343a). Report is 2 commits behind head on 2.5.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37958/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37958?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## 2.5 #37958 +/- ## ======================================= Coverage 68.87% 68.87% ======================================= Files 289 289 Lines 25481 25481 ======================================= Hits 17551 17551 Misses 7930 7930 ``` | [Components](https://app.codecov.io/gh/milvus-io/milvus/pull/37958/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [Client](https://app.codecov.io/gh/milvus-io/milvus/pull/37958/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `∅ <ø> (∅)` | | | [Core](https://app.codecov.io/gh/milvus-io/milvus/pull/37958/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `68.87% <ø> (ø)` | | | [Go](https://app.codecov.io/gh/milvus-io/milvus/pull/37958/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `∅ <ø> (∅)` | |

🚨 Try these New Features:

czs007 commented 4 days ago

go sdk test failed on:

[milvus-test : test] PASS testcases.TestIndexVectorDefault (88.64s)

[milvus-test : test] === RUN TestSearchOutputAllFields

[milvus-test : test] === PAUSE TestSearchOutputAllFields

[milvus-test : test] === CONT TestSearchOutputAllFields

[milvus-test : test] response_checker.go:21:

[milvus-test : test] Error Trace: /milvus/tests/go_client/common/response_checker.go:21

[milvus-test : test] /milvus/tests/go_client/testcases/helper/helper.go:178

[milvus-test : test] /milvus/tests/go_client/testcases/search_test.go:265

[milvus-test : test] Error: Received unexpected error:

[milvus-test : test] context deadline exceeded

[milvus-test : test] Test: TestSearchOutputAllFields

[milvus-test : test] [2024/11/23 08:11:21.499 +00:00] [INFO] [base/milvus_client.go:34] [Request] [method=DropCollection] [reqs="{\"collection_name\":\"pre_YnVnYL\"}"]

[milvus-test : test] [2024/11/23 08:11:21.500 +00:00] [INFO] [base/milvus_client.go:53] [Response] [method=DropCollection] [resp={}]

[milvus-test : test] [2024/11/23 08:11:21.500 +00:00] [DEBUG] [base/milvus_client.go:54] [Cost] [method=DropCollection] [cost=24.303µs]

[milvus-test : test] response_checker.go:21:

[milvus-test : test] Error Trace: /milvus/tests/go_client/common/response_checker.go:21

[milvus-test : test] /milvus/tests/go_client/testcases/helper/helper.go:127

[milvus-test : test] /usr/local/go/src/testing/testing.go:1169

[milvus-test : test] /usr/local/go/src/testing/testing.go:1347

[milvus-test : test] /usr/local/go/src/testing/testing.go:1589

[milvus-test : test] /usr/local/go/src/runtime/panic.go:523

[milvus-test : test] /usr/local/go/src/testing/testing.go:999

[milvus-test : test] /milvus/tests/go_client/common/response_checker.go:21

[milvus-test : test] /milvus/tests/go_client/testcases/helper/helper.go:178

[milvus-test : test] /milvus/tests/go_client/testcases/search_test.go:265

[milvus-test : test] Error: Received unexpected error:

[milvus-test : test] rpc error: code = DeadlineExceeded desc = context deadline exceeded

[milvus-test : test] Test: TestSearchOutputAllFields

[milvus-test : test] --- FAIL: TestSearchOutputAllFields (120.00s)

[milvus-test : test] [2024/11/23 08:11:21.546 +00:00] [INFO] [base/milvus_client.go:34] [Request] [method=GetFlushState] [reqs="{\"segmentIDs\":[454124835972163238],\"flush_ts\":454125022160617474,\"collection_name\":\"pre_kVAvGC\"}"]

czs007 commented 4 days ago

/approve /lgtm

sre-ci-robot commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/core/OWNERS](https://github.com/milvus-io/milvus/blob/2.5/internal/core/OWNERS)~~ [czs007] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment