search

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
31.06k stars 2.95k forks source link

fix: [2.4] Use correct policy merging growing&l0 and add unit tests (#37950) #37968

Closed congqixia closed 3 days ago

congqixia commented 6 days ago

Cherry-pick from master pr: #37950 Related to #37574

sre-ci-robot commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/querynodev2/delegator/OWNERS](https://github.com/milvus-io/milvus/blob/2.4/internal/querynodev2/delegator/OWNERS)~~ [congqixia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mergify[bot] commented 6 days ago

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.61%. Comparing base (4aca68a) to head (97efe12). Report is 22 commits behind head on 2.4.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37968/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## 2.4 #37968 +/- ## ========================================== + Coverage 72.24% 80.61% +8.36% ========================================== Files 1069 1070 +1 Lines 166979 167428 +449 ========================================== + Hits 120641 134978 +14337 + Misses 41919 28013 -13906 - Partials 4419 4437 +18 ``` | [Files with missing lines](https://app.codecov.io/gh/milvus-io/milvus/pull/37968?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/querynodev2/delegator/delta\_forward.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37968?src=pr&el=tree&filepath=internal%2Fquerynodev2%2Fdelegator%2Fdelta_forward.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnlub2RldjIvZGVsZWdhdG9yL2RlbHRhX2ZvcndhcmQuZ28=) | `70.50% <100.00%> (+8.47%)` | :arrow_up: | ... and [254 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/37968/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
weiliu1031 commented 3 days ago

/lgtm