milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
31.06k stars 2.95k forks source link

enhance: optimize self defined rust error #37975

Closed sunby closed 3 days ago

sunby commented 6 days ago

Prepare for issue: https://github.com/milvus-io/milvus/issues/37930

mergify[bot] commented 6 days ago

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify[bot] commented 6 days ago

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

sunby commented 5 days ago

rerun cpp-unit-test

sunby commented 5 days ago

/run-cpu-e2e

mergify[bot] commented 5 days ago

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.05%. Comparing base (fbb68ca) to head (938b6aa). Report is 23 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37975/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #37975 +/- ## ========================================== - Coverage 81.07% 81.05% -0.02% ========================================== Files 1360 1360 Lines 190775 190776 +1 ========================================== - Hits 154671 154640 -31 - Misses 30620 30644 +24 - Partials 5484 5492 +8 ``` | [Components](https://app.codecov.io/gh/milvus-io/milvus/pull/37975/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [Client](https://app.codecov.io/gh/milvus-io/milvus/pull/37975/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `72.33% <ø> (ø)` | | | [Core](https://app.codecov.io/gh/milvus-io/milvus/pull/37975/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `68.87% <ø> (ø)` | | | [Go](https://app.codecov.io/gh/milvus-io/milvus/pull/37975/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `83.22% <ø> (-0.02%)` | :arrow_down: | [see 39 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/37975/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
sunby commented 5 days ago

/run-cpu-e2e

mergify[bot] commented 5 days ago

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

sunby commented 4 days ago

/run-cpu-e2e

mergify[bot] commented 4 days ago

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

sunby commented 3 days ago

/run-cpu-e2e

mergify[bot] commented 3 days ago

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

sunby commented 3 days ago

/run-cpu-e2e

aoiasd commented 3 days ago

/lgtm

czs007 commented 3 days ago

/approve

sre-ci-robot commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/core/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/core/OWNERS)~~ [czs007] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment