milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
31.03k stars 2.95k forks source link

fix: the too long default root password does not take effect #37983

Closed SimFG closed 3 days ago

SimFG commented 4 days ago
mergify[bot] commented 4 days ago

@SimFG cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

SimFG commented 4 days ago

rerun cpp-unit-test

mergify[bot] commented 4 days ago

@SimFG cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify[bot] commented 4 days ago

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] commented 4 days ago

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (27c22d1) to head (9b30460). Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
internal/rootcoord/root_coord.go 42.85% 3 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37983/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #37983 +/- ## =========================================== + Coverage 68.87% 81.03% +12.15% =========================================== Files 289 1360 +1071 Lines 25481 190783 +165302 =========================================== + Hits 17551 154608 +137057 - Misses 7930 30672 +22742 - Partials 0 5503 +5503 ``` | [Components](https://app.codecov.io/gh/milvus-io/milvus/pull/37983/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [Client](https://app.codecov.io/gh/milvus-io/milvus/pull/37983/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `72.33% <ø> (∅)` | | | [Core](https://app.codecov.io/gh/milvus-io/milvus/pull/37983/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `68.87% <ø> (ø)` | | | [Go](https://app.codecov.io/gh/milvus-io/milvus/pull/37983/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `83.20% <75.00%> (∅)` | | | [Files with missing lines](https://app.codecov.io/gh/milvus-io/milvus/pull/37983?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [pkg/util/paramtable/component\_param.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37983?src=pr&el=tree&filepath=pkg%2Futil%2Fparamtable%2Fcomponent_param.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-cGtnL3V0aWwvcGFyYW10YWJsZS9jb21wb25lbnRfcGFyYW0uZ28=) | `98.36% <100.00%> (ø)` | | | [internal/rootcoord/root\_coord.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37983?src=pr&el=tree&filepath=internal%2Frootcoord%2Froot_coord.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcm9vdGNvb3JkL3Jvb3RfY29vcmQuZ28=) | `89.41% <42.85%> (ø)` | | ... and [1069 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/37983/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
SimFG commented 4 days ago

/run-cpu-e2e

mergify[bot] commented 4 days ago

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG commented 4 days ago

/run-cpu-e2e

mergify[bot] commented 4 days ago

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] commented 4 days ago

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG commented 4 days ago

rerun go-sdk

SimFG commented 4 days ago

/run-cpu-e2e

SimFG commented 4 days ago

/run-cpu-e2e

mergify[bot] commented 4 days ago

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] commented 4 days ago

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

SimFG commented 3 days ago

rerun go-sdk

SimFG commented 3 days ago

/run-cpu-e2e

mergify[bot] commented 3 days ago

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] commented 3 days ago

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG commented 3 days ago

/run-cpu-e2e

SimFG commented 3 days ago

rerun go-sdk

xiaofan-luan commented 3 days ago

/lgtm /approve

sre-ci-robot commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[cmd/OWNERS](https://github.com/milvus-io/milvus/blob/master/cmd/OWNERS)~~ [xiaofan-luan] - ~~[configs/OWNERS](https://github.com/milvus-io/milvus/blob/master/configs/OWNERS)~~ [xiaofan-luan] - ~~[internal/rootcoord/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/rootcoord/OWNERS)~~ [xiaofan-luan] - ~~[pkg/util/OWNERS](https://github.com/milvus-io/milvus/blob/master/pkg/util/OWNERS)~~ [xiaofan-luan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment