milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
31.06k stars 2.95k forks source link

enhance: add switch for local rpc enabled #37985

Closed chyezh closed 5 days ago

chyezh commented 6 days ago

issue: #33285

mergify[bot] commented 6 days ago

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] commented 6 days ago

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

chyezh commented 6 days ago

/run-cpu-e2e

chyezh commented 6 days ago

rerun go-sdk

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (27c22d1) to head (553f464). Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/coordinator/coordclient/registry.go 0.00% 2 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37985/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #37985 +/- ## =========================================== + Coverage 68.87% 81.04% +12.16% =========================================== Files 289 1360 +1071 Lines 25481 190788 +165307 =========================================== + Hits 17551 154621 +137070 - Misses 7930 30669 +22739 - Partials 0 5498 +5498 ``` | [Components](https://app.codecov.io/gh/milvus-io/milvus/pull/37985/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [Client](https://app.codecov.io/gh/milvus-io/milvus/pull/37985/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `72.33% <ø> (∅)` | | | [Core](https://app.codecov.io/gh/milvus-io/milvus/pull/37985/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `68.87% <ø> (ø)` | | | [Go](https://app.codecov.io/gh/milvus-io/milvus/pull/37985/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `83.21% <75.00%> (∅)` | | | [Files with missing lines](https://app.codecov.io/gh/milvus-io/milvus/pull/37985?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [pkg/util/paramtable/component\_param.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37985?src=pr&el=tree&filepath=pkg%2Futil%2Fparamtable%2Fcomponent_param.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-cGtnL3V0aWwvcGFyYW10YWJsZS9jb21wb25lbnRfcGFyYW0uZ28=) | `98.36% <100.00%> (ø)` | | | [internal/coordinator/coordclient/registry.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37985?src=pr&el=tree&filepath=internal%2Fcoordinator%2Fcoordclient%2Fregistry.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvY29vcmRpbmF0b3IvY29vcmRjbGllbnQvcmVnaXN0cnkuZ28=) | `88.46% <0.00%> (ø)` | | ... and [1069 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/37985/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
mergify[bot] commented 6 days ago

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] commented 6 days ago

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] commented 6 days ago

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

chyezh commented 6 days ago

/run-cpu-e2e

chyezh commented 6 days ago

rerun go-sdk

mergify[bot] commented 6 days ago

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] commented 6 days ago

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] commented 6 days ago

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] commented 6 days ago

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

jaime0815 commented 6 days ago

rerun go-sdk

jaime0815 commented 6 days ago

/run-cpu-e2e

mergify[bot] commented 6 days ago

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

jaime0815 commented 6 days ago

/run-cpu-e2e

mergify[bot] commented 6 days ago

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] commented 6 days ago

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] commented 5 days ago

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

jaime0815 commented 5 days ago

rerun cpp-unit-test

mergify[bot] commented 5 days ago

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

chyezh commented 5 days ago

rerun go-sdk

mergify[bot] commented 5 days ago

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

chyezh commented 5 days ago

rerun go-sdk

jaime0815 commented 5 days ago

/lgtm

sre-ci-robot commented 5 days ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/milvus-io/milvus/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment