milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
31.06k stars 2.95k forks source link

fix: Handle the error of the compaction queue being full #37989

Closed xiaocai2333 closed 2 days ago

xiaocai2333 commented 6 days ago

issue: #37988

mergify[bot] commented 6 days ago

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify[bot] commented 6 days ago

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

xiaocai2333 commented 6 days ago

rerun cpp-unit-test

xiaocai2333 commented 6 days ago

/run-cpu-e2e

mergify[bot] commented 6 days ago

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify[bot] commented 6 days ago

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 81.05%. Comparing base (27c22d1) to head (5127ad1). Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/compaction.go 25.00% 14 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37989/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37989?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #37989 +/- ## =========================================== + Coverage 68.87% 81.05% +12.17% =========================================== Files 289 1360 +1071 Lines 25481 190792 +165311 =========================================== + Hits 17551 154652 +137101 - Misses 7930 30652 +22722 - Partials 0 5488 +5488 ``` | [Components](https://app.codecov.io/gh/milvus-io/milvus/pull/37989/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [Client](https://app.codecov.io/gh/milvus-io/milvus/pull/37989/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `72.33% <ø> (∅)` | | | [Core](https://app.codecov.io/gh/milvus-io/milvus/pull/37989/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `68.87% <ø> (ø)` | | | [Go](https://app.codecov.io/gh/milvus-io/milvus/pull/37989/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `83.22% <25.00%> (∅)` | | | [Files with missing lines](https://app.codecov.io/gh/milvus-io/milvus/pull/37989?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/datacoord/compaction.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37989?src=pr&el=tree&filepath=internal%2Fdatacoord%2Fcompaction.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGF0YWNvb3JkL2NvbXBhY3Rpb24uZ28=) | `69.75% <25.00%> (ø)` | | ... and [1070 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/37989/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
czs007 commented 2 days ago

/approve /lgtm

sre-ci-robot commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/datacoord/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/datacoord/OWNERS)~~ [czs007] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment