search

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
31.03k stars 2.95k forks source link

fix: [2.4] Handle the error of the compaction queue being full #37990

Closed xiaocai2333 closed 11 hours ago

xiaocai2333 commented 4 days ago

issue: #37988

master pr: #37989

mergify[bot] commented 4 days ago

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 80.60%. Comparing base (93063ce) to head (f92d4ec). Report is 15 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/datacoord/compaction.go 25.00% 13 Missing and 2 partials :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37990/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37990?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## 2.4 #37990 +/- ## ========================================== + Coverage 72.34% 80.60% +8.26% ========================================== Files 1070 1070 Lines 167427 167443 +16 ========================================== + Hits 121130 134974 +13844 + Misses 41892 28035 -13857 - Partials 4405 4434 +29 ``` | [Files with missing lines](https://app.codecov.io/gh/milvus-io/milvus/pull/37990?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/datacoord/compaction.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37990?src=pr&el=tree&filepath=internal%2Fdatacoord%2Fcompaction.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGF0YWNvb3JkL2NvbXBhY3Rpb24uZ28=) | `76.79% <25.00%> (-0.98%)` | :arrow_down: | ... and [242 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/37990/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
mergify[bot] commented 3 days ago

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

xiaocai2333 commented 3 days ago

/run-cpu-e2e

mergify[bot] commented 3 days ago

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

xiaocai2333 commented 3 days ago

/run-cpu-e2e

mergify[bot] commented 3 days ago

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

xiaocai2333 commented 3 days ago

/run-cpu-e2e

mergify[bot] commented 3 days ago

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

xiaocai2333 commented 3 days ago

/run-cpu-e2e

czs007 commented 11 hours ago

/approve /lgtm

sre-ci-robot commented 11 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/datacoord/OWNERS](https://github.com/milvus-io/milvus/blob/2.4/internal/datacoord/OWNERS)~~ [czs007] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment