search

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
31.06k stars 2.95k forks source link

fix: [2.5] Handle the error of the compaction queue being full #37991

Closed xiaocai2333 closed 2 days ago

xiaocai2333 commented 6 days ago

issue: #37988

master pr: #37989

sre-ci-robot commented 6 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaocai2333 To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed. You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[internal/datacoord/OWNERS](https://github.com/milvus-io/milvus/blob/2.5/internal/datacoord/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mergify[bot] commented 6 days ago

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 81.01%. Comparing base (c35045e) to head (be351c6). Report is 4 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/datacoord/compaction.go 25.00% 14 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37991/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37991?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## 2.5 #37991 +/- ## ========================================== - Coverage 81.04% 81.01% -0.03% ========================================== Files 1360 1360 Lines 190664 190680 +16 ========================================== - Hits 154515 154471 -44 - Misses 30655 30699 +44 - Partials 5494 5510 +16 ``` | [Components](https://app.codecov.io/gh/milvus-io/milvus/pull/37991/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [Client](https://app.codecov.io/gh/milvus-io/milvus/pull/37991/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `72.16% <ø> (ø)` | | | [Core](https://app.codecov.io/gh/milvus-io/milvus/pull/37991/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `68.87% <ø> (ø)` | | | [Go](https://app.codecov.io/gh/milvus-io/milvus/pull/37991/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `83.17% <25.00%> (-0.04%)` | :arrow_down: | | [Files with missing lines](https://app.codecov.io/gh/milvus-io/milvus/pull/37991?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/datacoord/compaction.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37991?src=pr&el=tree&filepath=internal%2Fdatacoord%2Fcompaction.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGF0YWNvb3JkL2NvbXBhY3Rpb24uZ28=) | `69.75% <25.00%> (-1.76%)` | :arrow_down: | ... and [31 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/37991/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
mergify[bot] commented 5 days ago

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

xiaocai2333 commented 5 days ago

/run-cpu-e2e

mergify[bot] commented 5 days ago

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

xiaocai2333 commented 5 days ago

/run-cpu-e2e

xiaocai2333 commented 2 days ago

/close close with https://github.com/milvus-io/milvus/pull/37989

sre-ci-robot commented 2 days ago

@xiaocai2333: Closed this PR.

In response to [this](https://github.com/milvus-io/milvus/pull/37991#issuecomment-2507116359): >/close >close with https://github.com/milvus-io/milvus/pull/37989 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.