search

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
31.03k stars 2.95k forks source link

enhance: [2.4] Grant v2 proxy service supports operatePrivilegeV2 #37997

Closed shaoting-huang closed 3 days ago

shaoting-huang commented 4 days ago

should support operatePrivilegeV2 service on Proxy to let SDK utilizes cherry-pick from master: https://github.com/milvus-io/milvus/pull/37945 issue: https://github.com/milvus-io/milvus/issues/37031

mergify[bot] commented 4 days ago

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.63%. Comparing base (e928e15) to head (1245ae5). Report is 8 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/distributed/proxy/service.go 0.00% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37997/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37997?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## 2.4 #37997 +/- ## ========================================== + Coverage 80.62% 80.63% +0.01% ========================================== Files 1070 1070 Lines 167379 167377 -2 ========================================== + Hits 134942 134963 +21 + Misses 28008 27994 -14 + Partials 4429 4420 -9 ``` | [Files with missing lines](https://app.codecov.io/gh/milvus-io/milvus/pull/37997?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [...nternal/distributed/proxy/httpserver/handler\_v2.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37997?src=pr&el=tree&filepath=internal%2Fdistributed%2Fproxy%2Fhttpserver%2Fhandler_v2.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGlzdHJpYnV0ZWQvcHJveHkvaHR0cHNlcnZlci9oYW5kbGVyX3YyLmdv) | `91.96% <100.00%> (-0.02%)` | :arrow_down: | | [internal/distributed/proxy/service.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37997?src=pr&el=tree&filepath=internal%2Fdistributed%2Fproxy%2Fservice.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGlzdHJpYnV0ZWQvcHJveHkvc2VydmljZS5nbw==) | `84.92% <0.00%> (-0.23%)` | :arrow_down: | ... and [33 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/37997/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
shaoting-huang commented 3 days ago

/run-cpu-e2e

mergify[bot] commented 3 days ago

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

shaoting-huang commented 3 days ago

/run-cpu-e2e

mergify[bot] commented 3 days ago

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

sre-ci-robot commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/distributed/OWNERS](https://github.com/milvus-io/milvus/blob/2.4/internal/distributed/OWNERS)~~ [congqixia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
shaoting-huang commented 3 days ago

/run-cpu-e2e