milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
31.03k stars 2.95k forks source link

enhance: Mark cgo thread with tag name #38000

Closed congqixia closed 3 days ago

congqixia commented 4 days ago

Related to #37999

This PR add SetThreadName API for marking cgo thread and utilize it when initializing cgo worker.

sre-ci-robot commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/core/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/core/OWNERS)~~ [congqixia] - ~~[internal/querynodev2/segments/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/querynodev2/segments/OWNERS)~~ [congqixia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mergify[bot] commented 4 days ago

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] commented 4 days ago

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] commented 4 days ago

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] commented 4 days ago

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify[bot] commented 4 days ago

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

congqixia commented 4 days ago

rerun cpp-unit-test

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 68.18182% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (27c22d1) to head (b339976). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/querynodev2/segments/pool.go 78.94% 3 Missing and 1 partial :warning:
internal/core/src/segcore/segcore_init_c.cpp 0.00% 3 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/38000/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/38000?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #38000 +/- ## =========================================== + Coverage 68.87% 81.07% +12.19% =========================================== Files 289 1360 +1071 Lines 25481 190781 +165300 =========================================== + Hits 17551 154671 +137120 - Misses 7930 30627 +22697 - Partials 0 5483 +5483 ``` | [Components](https://app.codecov.io/gh/milvus-io/milvus/pull/38000/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [Client](https://app.codecov.io/gh/milvus-io/milvus/pull/38000/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `72.33% <ø> (∅)` | | | [Core](https://app.codecov.io/gh/milvus-io/milvus/pull/38000/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `68.87% <0.00%> (-0.01%)` | :arrow_down: | | [Go](https://app.codecov.io/gh/milvus-io/milvus/pull/38000/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `83.24% <78.94%> (∅)` | | | [Files with missing lines](https://app.codecov.io/gh/milvus-io/milvus/pull/38000?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/core/src/segcore/segcore\_init\_c.cpp](https://app.codecov.io/gh/milvus-io/milvus/pull/38000?src=pr&el=tree&filepath=internal%2Fcore%2Fsrc%2Fsegcore%2Fsegcore_init_c.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvY29yZS9zcmMvc2VnY29yZS9zZWdjb3JlX2luaXRfYy5jcHA=) | `38.77% <0.00%> (-2.53%)` | :arrow_down: | | [internal/querynodev2/segments/pool.go](https://app.codecov.io/gh/milvus-io/milvus/pull/38000?src=pr&el=tree&filepath=internal%2Fquerynodev2%2Fsegments%2Fpool.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnlub2RldjIvc2VnbWVudHMvcG9vbC5nbw==) | `91.30% <78.94%> (ø)` | | ... and [1070 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/38000/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
congqixia commented 4 days ago

rerun go-sdk

congqixia commented 3 days ago

/run-cpu-e2e

mergify[bot] commented 3 days ago

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

congqixia commented 3 days ago

/run-cpu-e2e