minaskar / zeus

⚡️ zeus: Lightning Fast MCMC ⚡️
https://zeus-mcmc.readthedocs.io/
GNU General Public License v3.0
225 stars 34 forks source link

get_last_sample should be function #10

Closed jeremysanders closed 3 years ago

jeremysanders commented 3 years ago

This is a minor issue, as I can work around the difference using get_chain instead.

In emcee, get_last_sample is a function which returns the last sample. In zeus this is a property. For compatibility, it would be useful to match the emcee API. It also doesn't make sense to me to use a property called get_XXX.

PS Thanks for working on this software and algorithm - initial tests are looking good

minaskar commented 3 years ago

Hi Jeremy, Thanks a lot for spotting this! I'll make sure. it's fixed in the next release.

minaskar commented 3 years ago

This is done in version 2.2.2.

jeremysanders commented 3 years ago

Thanks very much!