minddust / bootstrap-progressbar

progressbar interactions for twitter bootstrap 2 & 3
www.minddust.com/project/bootstrap-progressbar
MIT License
577 stars 160 forks source link

fix attempt for bar < 100 pixels and no decrease text animation. #19

Open rck109d opened 11 years ago

rck109d commented 11 years ago

This change addresses the issue where a progress bar of less than 100 pixels will show incorrect text in some situations.

I understood the problem to be that for bars with fewer than 100 pixels comparing ratios between bar pixels to the percentage of the represented fraction will not always be equal.

For example the ratio 1 / 13 as shown on a bar of 45 pixels: 1/13 = 0.076... ~= 8% 45 * (1/13) = 3.4... ~= 3 pixels 3 pixels / 45 pixels = 0.066... ~= 7% The code was expecting the 7% to equal 8% before terminating. Because this condition never happens the interval function keeps running and overwrites the progress bar text even after future changes!

At first I thought different rounding would resolve it (round the 7.6 down to 7 and the 6.6 up to 7). However I think that won't work in every case. I now prefer the included solution also because it's easier to understand.

The interval function is now named intervalUpdate and it stores the previous percentage of pixel transition progress in intervalUpdate.prev_percentage and compares this to current_percentage. If these two values are equal it is assumed that no more progress is being made and so the interval will terminate.

rck109d commented 11 years ago

the add-on commit prevents the text updating interval from terminating prematurely in the case of starting high and going low (e.g. 90% to 10%).

minddust commented 11 years ago

@rck109d thanks for diggin in! will check this on sunday - got a lot of work to do right now.

minddust commented 10 years ago

@rck109d long time no see. sorry about that.

without testing - i would say it could be for slow transitions, wide bar and fast refresh cycles that your condition is true even before reaching the final value. that's one of the reasons why i tested against percentage.