mindee / mindee-api-python

Mindee API Helper Library for Python
https://mindee.com
MIT License
39 stars 5 forks source link

Dependency hard pin `requests` in 4.14.0 version #275

Closed sshishov closed 1 week ago

sshishov commented 1 week ago

Prerequisites

Put an X between the brackets on this line if you have done all of the following:

Description

Requests is pinned to obsolete version, any reason

"requests~=2.31.0",

Please note that previous version 4.13.0 did not have such a pin.

Steps to Reproduce

  1. Create virtualenv
  2. Install latest requests
  3. Install latest mindee
  4. Observe that the requests was downgraded

Expected behavior:

Third package library should not hard pin the base requirements to patch version upgrades only

Actual behavior:

Only version 2.31.x is allowed

Reproduces how often:

Reproduced always

Versions

Affected: 4.14.0 Python: 3.10.11

Additional Information

N/A

sebastianMindee commented 1 week ago

Hello, the request version was historically pinned to allow retro-compatibility with python 3.7. We'll loosen it to >= 2.31.0 in the next release (1.14.1). See #276

That said, 4.13.0 did have such a pin: https://github.com/mindee/mindee-api-python/blob/6237dc5cb9319240549c472c746a2022b50c0bf1/setup.cfg#L38. The only change has been that it moved to the pyproject.toml file.

sshishov commented 6 days ago

Thank you very much @sebastianMindee for prompt response and for blazing fast fix of the issue. Looking forward to meet version 1.14.1.