mindspore-lab / mindone

one for all, Optimal generator with No Exception
https://mindspore-lab.github.io/mindone/
Apache License 2.0
353 stars 67 forks source link

AttnBlock3D 'bug' fix #526

Closed chenyang23333 closed 3 months ago

chenyang23333 commented 3 months ago

What does this PR do?

Fixes # (issue)

Adds # (feature)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

@xxx

SamitHuang commented 3 months ago

这样改相当于重新引入原v1.0的bug (时间轴T未正确permute),we should align to the right thing instead of the format. 关于这个bug,原仓已讨论且已合入 https://github.com/PKU-YuanGroup/Open-Sora-Plan/issues/171

且1)即使用加载原权重,bug fix后,重建视频正确。2)如果v1.0用新数据重训,bug fix后,效果会更好。