search

minetest-mods / drawers

[MTG/MCL2] A Minetest Mod adding storage drawers in different sizes and wood types.
Other
19 stars 26 forks source link

Brutal Crash when adding an item to a full drawer via a Drawer Controller and TA Distributor #92

Open MetaNomad opened 7 months ago

MetaNomad commented 7 months ago

This one was hard to spot and to figure out that it comes from this mod, because when the game crash, it just brutally shutdown without any prior, no error message, nothing useful in debug.txt to link it with this mod.

How to reproduce :

Minetest 5.8.0 + techage 2023-11-26 on Linux Debian 12

Connect a TA2 Distributor (blocking mode) to a Drawer Controller, itself connected to multiples x4 Drawers. When all the drawers get full, if an item is configured on the distributor to go to the drawer controller, and the drawer controller have no room to store the item in any drawer that is connected, the game crash brutally when the Distributor try to send it thru tube, without any error message.

I couldn't figure out what caused that...

Niklp09 commented 7 months ago

just brutally shutdown without any prior, no error message, nothing useful in debug.txt

This looks like an engine crash/error then.

Connect a TA2 Distributor (blocking mode) to a Drawer Controller, itself connected to multiples x4 Drawers. When all the drawers get full, if an item is configured on the distributor to go to the drawer controller, and the drawer controller have no room to store the item in any drawer that is connected

Could you share a screenshot of this setup w/ us? (you can attach files to github comments)

MetaNomad commented 7 months ago

screenshot_20240501_035527 Here's the setup

screenshot_20240501_035608 It happens when the distributor try to send coal lumps to the drawer controller. The four drawers with coal lumps are 100% full. It crashes even if there is an empty unassigned drawer on the row.

screenshot_20240501_035624 I tried the same setup but with a regular chest, and no crash

screenshot_20240501_035635 The distributor just turn on "blocked" mode and stop

With the drawer controller, sometimes it does as well, but whenever something is added to the distributor, and he try again, it crashes

Niklp09 commented 7 months ago

Can't reproduce, works fine on mt 5.9-dev and latest techage master.