use player attributes - Githubissues

minetest-mods / stamina

Adds hunger (stamina) to minetest.

17 stars 19 forks source link

use player attributes #11

Closed sofar closed 7 years ago

sofar commented 7 years ago

requires a dev release of minetest.

sofar commented 7 years ago

@bewlay

This whole series looks quite good actually. It's quite messy in appearance, but I wouldn't have come to any different conclusion, really.

sofar commented 7 years ago

4efa141

sofar commented 7 years ago

merged - thanks a ton!

sofar commented 7 years ago

Note, I just discovered a bug in this and it broke the mod. Next time, please verify with luacheck that the code actually works!

bewlay commented 7 years ago

I'm quite new to lua, so I wasn't aware of luacheck. I will use it in the future, thanks! Still, I just looked through the latest commits to see what I did wrong, and couldn't find anything. If you're referring to the extra "end" you removed in the lastest patch, it looks like this actually wasn't my fault. I also believe I would have noticed that while testing. If not, I would appreciate if you could elaborate, so I can improve my lua coding abilities.