search

minetest / minetest_docs

Minetest Engine documentation (Work in progress. Meanwhile, please refer to lua_api.txt and dev.minetest.net)
Other
22 stars 13 forks source link

Update note about texture modifier memleaks #48

Closed appgurueu closed 1 year ago

appgurueu commented 1 year ago

Verify that https://github.com/minetest/minetest/pull/12514 fixes texture modifier memleaks (does it?)

20kdc commented 1 year ago

It doesn't fix texture modifier leaks. The original version of the PR, before the change in direction, was part of a comprehensive solution to deal with leaks caused by the server having to use different paths for new uploaded images (thus slowly flooding the client modifier cache). Think "MineClone maps" if you want an idea of what could cause this.

EDIT: Just to clarify, after the change in direction, this is no longer what the PR does. Only the parts that track changes to images in the client texture cache remain.

appgurueu commented 1 year ago

Alright, thanks for clarifying!