minetest / minetest_game

Minetest Game - A lightweight and well-maintained base for modding [https://github.com/minetest/minetest/]
http://minetest.net/
Other
1.43k stars 578 forks source link

Double Chests #1973

Closed Gerold55 closed 6 years ago

Gerold55 commented 6 years ago

Can we have double chests?

MarkuBu commented 6 years ago

There are several mods that add double chests

Gerold55 commented 6 years ago

Yes I know but I am wanting it added in game :)

MarkuBu commented 6 years ago

It's a nice to have, but I don't think it is necessary and there are more important things to implement.

Just my 2 cent

Gerold55 commented 6 years ago

Yeah it's just a feature that would be nice the aesthetic of it would be nice. And more storage in on inventory :)

paramat commented 6 years ago

Yes it is low priority. MTG tends to do everything simply, and the opening single chests were a lot of work which would need to be duplicated, for something that is only of visual value -1

Gerold55 commented 6 years ago

Other than visual you would have extra chest space.

ghost commented 6 years ago

only of visual value

Except having chests with twice as much slots than a single chest.

paramat commented 6 years ago

Hm good point, i was thinking 2 chests side by side is equivalent, but of course not as convenient to use. Sorry, removed my -1, neutral.

paramat commented 6 years ago

This requires making a model which i can't do (and i am not interested in this task). It seems no other dev has time for MTG so you may have to find someone willing to code this and make the model.

benrob0329 commented 6 years ago

The model could remain the same, but have the texture change accordingly. (Two chest models next to each other, rightclicking on one opens the other)

Gerold55 commented 6 years ago

That's what I was thinking also :)

paramat commented 6 years ago

Nooo that would look bad, and working with 2 separate nodes will make things more complex.

MarkuBu commented 6 years ago

That would be like doors earlier. Looked ugly because both halves doesn't open at the same time

Ferk commented 6 years ago

Would a chest formspec with double inventory fit in a small mobile screen?

Minecraft might have double chests, but the normal ones have half the storage space than Minetest.

GreenXenith commented 6 years ago

If you go by large chest behavior in Minecraft (which IMO makes sense), if you dig one side of the large chest, it turns into a small chest (obviously on the opposite side of the chest you dug) and drops items that don't fit. If this behavior were wanted for chests in Minetest, we would have to detect which part of the chest the player is pointing at (because it's a 2-block model with a 2-block sized collision box), which I don't think is possible, but I could be wrong.

ghost commented 6 years ago

Would a chest formspec with double inventory fit in a small mobile screen?

Works flawlessly with this mod.

TumeniNodes commented 6 years ago

The model could remain the same, but have the texture change accordingly. (Two chest models next to each other, rightclicking on one opens the other)

@benrob0329 the model cannot remain the same since the recent changes to chest. a second model of a double (open) chest is required, and would have to be set up so that there is a way for a player to be able to decide if a chest set next to another is to remain a single or turn it into a double. Nathan S would be the person I would contact for the model. ^ @benrob0329 Don't know why I made the above statement, knowing you are a capable modeler. Either way, you or Nathan S could create a new model for open double chests, which could be added to the current double chest mod, mentioned or, perhaps submitted as a PR later. I would choose the former.

And I also feel this should be a mod, rather than built into the game.

TekhnaeRaav commented 6 years ago

I don't agree with this being a mod, but this is low priority so I'm afraid this will have probably have to wait. Especially due to the difficulty.

TumeniNodes commented 6 years ago

It's actually not that difficult (I think) Just a matter of a second model added, for double chest open. and fine tuning HybridDog's connected chests https://github.com/HybridDog/connected_chests ,and then integrate it into default (easy peasy) ha

Though, I honestly feel that chests should be split into their own (like doors are)

benrob0329 commented 6 years ago

What if you right-clicked on the side of a chest to combine it with the one you're holding? Then we don't add an extra thing to craft, and have the opportunity to have more than a double chest. Also, no extra model needed if we swap both/all nodes at the same time (vmanip anyone?).

paramat commented 6 years ago

New models (and probably textures) per size are still needed. Although i like the crazy idea of a triple chest, double is probably enough.

TumeniNodes commented 6 years ago

The formspec covers the chest when opened but, the 2d model w/ UVmap would be because, if you're going to do something..., do it right. Other than that, HybridDog's mod works well, and has a nice formspec layout, etc.

Though I would like to see using the left shift key to using the right shift key (or something) to connect. Would actually also love to see the formspec background transparent enough to see the open chest through it, but not enough to be a distraction.

I'm actually beginning to change my mind, in regards to this not being added, rather than as a mod. Especially if chests would be split into it's own default/mod, which just makes sense.

This would probably be something users are very happy with. (a lil' su-en new to distract from "when is the 0.5.0 release date?") (big smile emoticon)

TumeniNodes commented 6 years ago

double chest obj.zip

in case anyone wants to have a go at it. I simply stretched out the model for chest from default. I believe it was sofar's work. I might work on the UVs tomorrow or over the weekend

cx384 commented 6 years ago

This is minetest not minecraft! Why do we even take so much features from minecraft? A few more or less recent examples: walls, carts, trapdoors, boats, iron bars, glass pains, fence gates, opening chests, flint and steel, dungeon loot, beds, tnt ... Anyone who wants to play a minecraft clone could use mineclone 2.

Gerold55 commented 6 years ago

Well the things that we add are also in real life. I thought it would be good to add to MT

MarkuBu commented 6 years ago

Why do we even take so much features from minecraft?

Well, tell us what we can use that is not already used in Minecraft? Make a game that does not contain any Minecraft content and is still fun. I think if you find 10 things that make sense and aren't used in Minecraft or a mod, then you're a genius.

But even then you don't have enough for a game

Ferk commented 6 years ago

@MarkuBu there are a lot of videogames that have nothing to do with Minecraft and are fun. Honestly I would have preferred if MTG (and Minetest before it) had been more distanced from Minecraft from the very beginning. It could had been set in an alien planet, or a fantasy land or city landscapes or underground post-apocaliptic worlds (Ultima underworld or Arx Fatalix style). It would have been great if there were more gameplay elements that clearly made a big and lasting distinction that made players realize from the get-go that the game does not try to be just like a Minecraft sandbox game.

A lot of Minetest works like Minecraft, even arbitrary things unrelated to the "fun" that might have actually been more interesting had they been different, or that are inconsistent just for the sake of being like Minecraft.

I was making a list of several arbitrary things from MC that got into MT and could have been made different yet fun, but I realized the post was getting too big for an offtopic so I'd rather leave that for another time and place.

TekhnaeRaav commented 6 years ago

Just my opinion on double chests if it matters, I think double chests should be a thing you craft.:)

Why do we even take so much features from minecraft?

Well, minecraft isn't a bad game, and a lot of these features are just good features for the game. Whether or not it's from minecraft doesn't matter as long as it makes the game better.

Ferk commented 6 years ago

Well, minecraft isn't a bad game, and a lot of these features are just good features for the game

Yes, but there are a lot of great games to draw inspiration from, it doesn't have to be always Minecraft. I'm not particularly talking about this suggestion, but even features from Minecraft that are not so good or make little sense have been part of Minetest for a long time.

paramat commented 6 years ago

Forgetting about other games, a double chest makes sense by providing a larger inventory in one formspec, useful for sorting and organisation. In MTG, as you know, i try to make sure we never do something just because it is in another game.

rubenwardy commented 6 years ago

I've never felt the need for double chests, but it's a fairly popular request and is obviously useful for other people so I'm in favour.

Edit: Just seen there's a number of down votes on the first post, so this isn't as popular as I thought

Also, are you actually in favour @paramat ?

TumeniNodes commented 6 years ago

@rubenwardy that's more label switching than at a black friday sale haha.

I honestly don't see the big fuss over adding/adopting this feature. Regardless of it existing in MC it: A: adds a nice visual B: can be very useful to players C: aw c'mon..., it's pretty cool D: because

My points above are, for the most part, meaningless, and not very strong arguments, I admit. However..., a poll, whether here, or on the forum, etc..., proves absolutely nothing in terms of end users. When I think about features like this, in-game..., I think "will kids be glad to see it added?", in this case, I think yes.

I also think, there are enough unique aspects related to Minetest Game, to justify similarities. Unless they have some patent, or copyright on double wide chests..., I don't see the problem.

Either way, they will be available to end users, whether as a HybridDog's mod, or from the game itself. it would also create more sense of splitting chests into their own mod within MTG (so that is the biggest reason I have changed my mind to, being for it to be added) edit: Actually my thought is to move chests (and keys) into the doors mod (as doors and chests are "keyed_items") But that is a whole other issue so, sorry for breaking protocol

paramat commented 6 years ago

@rubenwardy I'm neutral, there are mods after all. I certainly won't do the work of adding these. It's low priority.

Wuzzy2 commented 6 years ago

TBH there's no need for double chests. It's just a ton of work, needs tons of testing and adds a truckload of new possible bugs just for eye candy. Double chests don't even really add anything to gameplay, except for a minor convenience.

I know from first-hand experience how finnicky double chests can be, as a developer of a Minecraft clone myself. It's really not worth all the hassle. It's not that it's impossible, it's just that it's way too much work.

My friendly advice: Don't waste your time on this and reject this suggestion.

paramat commented 6 years ago

@Ezhh shall we close? I'm more :-1: than neutral.

Ezhh commented 6 years ago

I'm leaning toward :-1: and happy with closing.

Wuzzy summed it up quite well in my opinion.