dependency bug with `Portable.System.DateTimeOnly`

mini-software / MiniExcel

Fast, Low-Memory, Easy Excel .NET helper to import/export/template spreadsheet (support Linux, Mac)

https://www.nuget.org/packages/MiniExcel/

Apache License 2.0

2.81k stars 342 forks source link

dependency bug with `Portable.System.DateTimeOnly` #594

Closed MarcelWilke42 closed 6 months ago

MarcelWilke42 commented 6 months ago

MiniExcel Version

1.32.0

Description

Since #576 there is a dependency bug.

Here it is explicitly checked that this is only included with netstandard2.0. But since MiniExcel is only built for net45 and netstandard2.0 this means that e.g. a net8 project that includes MiniExcel (in this case the netstandard2.0 lib) automatically includes Portable.System.DateTimeOnly.

This could only be prevented cleanly by building MiniExcel in different frameworks.

shps951023 commented 6 months ago

@MarcelWilke42 Fixed v1.32.1