miniflux / v2

Minimalist and opinionated feed reader
https://miniflux.app
Apache License 2.0
6.44k stars 702 forks source link

feat: Global Block & Keep filters #2677

Open privatmamtora opened 3 weeks ago

privatmamtora commented 3 weeks ago

Do you follow the guidelines?

Added new feature to enable Global Keep & Block Rules. Advantages

Format: FieldName(RegEx)~FieldName(RegEx)~...

FieldName options: Title, URL, CommentsURL, Content, Author, Tags

Addresses: #1326 , #1654 , #1953 , #2583 (maybe)

fguillot commented 1 week ago

Format: FieldName(RegEx)~FieldName(RegEx)~...

FieldName options: Title, URL, CommentsURL, Content, Author, Tags

From a user perspective, I'm wondering if ~ is the right choice for rule separator. Would not be better to have one rule per line in a textarea?

The syntax could be simplified:

EntryURL=(?i)example
Title=(?i)Test

instead of

URL((?i)example)~Title((?i)Test)

I would make the field names explicit to avoid possible confusions: URL -> EntryURL.

privatmamtora commented 1 week ago

Ok will make the following changes:

  1. Use a text area, 1 rule per-line a. Eliminates the ~ separator b. Makes it easier to modify and review rules
  2. Use = to separate FieldName and rules
  3. I'll change the field names to the following:
    • EntryTitle
    • EntryURL
    • EntryCommentsURL
    • EntryContent
    • EntryAuthor
    • EntryTag
privatmamtora commented 1 week ago

Completed making the changes @fguillot