search

minio / mc

Unix like utilities for object store
https://min.io/download
GNU Affero General Public License v3.0
2.88k stars 550 forks source link

Only warn if less than 28 days to cert expires #5077

Closed klauspost closed 2 weeks ago

klauspost commented 2 weeks ago

Description

Fixes #5076 as much as reasonable.

How to test this PR?

Long-lived certs..

Types of changes

xtian-socgen commented 2 weeks ago

I'm adding a comment here as my original issue was closed too fast...

Although I understand the point behind "mc is just an admin tool that is build only to be used with minio and not by end users", I wonder if this is just reality. I know plenty of people using it instead of the aws cli, because it's just 1M times easier to use. This is why, I created the issue at first, as it looked like to me that this was a real problem for non-admin usage.

Now that its usage is clarified, I understand this was not the good way to use it, which is sad, but its like this. As this feature is a "customer" need, I can't go against it.

xtian-socgen commented 2 weeks ago

Thank you any way for such a fast answer!

klauspost commented 2 weeks ago

The check is pointless if opt-in, but it shouldn't warn you months in advance.

You will have to deal with the warning.