search

minio / minio-dotnet

MinIO Client SDK for .NET
https://docs.min.io/docs/dotnet-client-quickstart-guide.html
Apache License 2.0
575 stars 230 forks source link

using interface IReadOnlyDictionary instead of a dicrionary in TagSet and Tagging #1149

Open danilenko-a opened 3 months ago

danilenko-a commented 3 months ago

Interface limitation: The dictionary with tags is only needed for enumeration.

danilenko-a commented 2 months ago

Pull request updated

ebozduman commented 2 months ago

That's great @danilenko-a! Could you also add some functional test(s) for this PR/change? Maybe, you can do the testing simply by adding some assertions or checks in existing functional tests about Tags, ILM and Replication where IReadOnlyDictionary is introduced. Please make sure the tests/checks are created for .../minio-dotnet/Mino.Functional.Tests.