search

ministryofjustice / bootstrap-cfn

Opinionated layer for AWS CloudFormation
Other
17 stars 9 forks source link

Try to delete SSL certs only if defined in cf template #242

Closed ltsampros closed 7 years ago

ltsampros commented 7 years ago

Try to delete SSL certs only if defined in cf template

The obvious culprit is that we can call cfn_delete after we've changed the template file though and that makes things a bit more complicated. Alternatively, we could ignore that and just continue if exception occurs

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.01%) to 59.366% when pulling 9194c872ba48d020a4ff037324867ab0755cd2ce on delete-cert-cfn-delete into f2f3afe0b5c4d77593a3107421c4745b6ab8ecb3 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 59.399% when pulling 59eebf49b7b971bc6688d95cff133ab7b42caf2d on delete-cert-cfn-delete into f2f3afe0b5c4d77593a3107421c4745b6ab8ecb3 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.04%) to 60.032% when pulling e06bf93f392a59573bcccfd19d9b1a085d0aad24 on delete-cert-cfn-delete into 0792bed105f58835348bb8f7c2984f027060c4a0 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 59.947% when pulling e4c0179f8ea45b797ea653dcd1dbaa0c47cc4da2 on delete-cert-cfn-delete into cec3e07f253df15b9aa39767aea9d36c368e082e on master.