search

minkphp / MinkSelenium2Driver

Selenium2 (webdriver) driver for Mink framework
MIT License
507 stars 163 forks source link

Upgrade JS syn to v0.15.0 #358

Closed mvorisek closed 1 year ago

mvorisek commented 2 years ago

syn.js downloaded by npm install syn and moved from node_modules/syn/dist/global/syn.js (no local compilation, only non-minified version is available, thankfully, as it is much better for debugging)

replaces https://github.com/minkphp/MinkSelenium2Driver/pull/333

fixes #279 and maybe also #20

codecov[bot] commented 2 years ago

Codecov Report

Merging #358 (0405fe7) into master (5d15043) will increase coverage by 0.60%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #358      +/-   ##
============================================
+ Coverage     90.02%   90.62%   +0.60%     
  Complexity      150      150              
============================================
  Files             1        1              
  Lines           421      448      +27     
============================================
+ Hits            379      406      +27     
  Misses           42       42
Impacted Files Coverage Δ
src/Selenium2Driver.php 90.62% <100.00%> (+0.60%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

aik099 commented 2 years ago

@mvorisek , I've rerun the builds and they seem to pass with a new test.

mvorisek commented 2 years ago

@aik099 yes, please merge this PR as well and close the 3 mentioned #/issues in the description then.

aik099 commented 2 years ago

@aik099 yes, please merge this PR as well and close the 3 mentioned #/issues in the description then.

I'll wait for @stof to see if he has anything to add.

mvorisek commented 2 years ago

Hi @stof, this PR is approved but Alex wants your feedback as well, can you please give this PR a green light?

mvorisek commented 1 year ago

@stof @aik099 can this PR be merged? Thank you.

aik099 commented 1 year ago

@mvorisek , I guess you need to add a line to the changelog explaining the bug, that was fixed with this PR: the numbers from 0 to 9 passed as strings were treated as ASCII codes.

After that, I'll try to merge this PR.

mvorisek commented 1 year ago

@aik099 CHANGELOG added

aik099 commented 1 year ago

Merged. Thank you @mvorisek .

mvorisek commented 1 year ago

@aik099 Thank you, would it be possible to tag a new release please?

aik099 commented 1 year ago

How that would help you?

mvorisek commented 1 year ago

I no longer need it as I desided to fork this repo..

But I would like to get my changes still merged, especially https://github.com/minkphp/MinkSelenium2Driver/pull/359. Thank you.