search

minkphp / MinkZombieDriver

Zombie.js driver for Mink framework
41 stars 49 forks source link

Using "Behat\Mink\Driver\NodeJS\Server::createTemporaryServer" replaces user provided server code #160

Closed aik099 closed 8 years ago

aik099 commented 8 years ago

The Behat\Mink\Driver\NodeJS\Server::createTemporaryServer method would generate and replace existing server code with generated one. This is a problem for cases, when during server construction custom server path was provided.

Related issues:

stof commented 8 years ago

I don't understand what you mean here. This method is called only when no path is provided.

stof commented 8 years ago

Actually, I found another place calling this method, but it is now useless thanks to #162 so I'm fixing it.

aik099 commented 8 years ago

I've meant this line: https://github.com/stof/MinkZombieDriver/blob/d0caf88e0812b79b268323c6fe29d8f898db9824/src/NodeJS/Server.php#L183

$this->serverPath = $this->createTemporaryServer();

that is called from setNodeModulesPath method.

aik099 commented 8 years ago

Then this is solved by #163.