search

minrk / wurlitzer

Capture C-level stdout/stderr in Python
MIT License
194 stars 24 forks source link

drop python<=3.7 support #90

Open kloczek opened 5 months ago

kloczek commented 5 months ago

According to https://endoflife.date/python python 3.7 has been EOSed almost year ago. Filter all code over pyupgrade --py3.8-plus.

minrk commented 5 months ago

Thanks for the PR! But for such a small, simple project I'd rather not drop support for things that work just fine without a reason.

kloczek commented 5 months ago

https://pypistats.org/packages/wurlitzer

minrk commented 5 months ago

From what I see, that link makes a good case to at least keep 3.7, and might as well keep 3.6, since removing it doesn't solve anything that I'm aware of.

Does removing support where we know it works fine with no other changes solve a problem for you that I'm not seeing?

kloczek commented 5 months ago

With python_requires=">=3.8" pypi will offer for all those with python<=3.7 current release. If this PR will be merged and released its .whl will be no longer offered for those people. No one will be hist.

minrk commented 5 months ago

OK. I don't like to drop support before maintaining support causes a problem. 3.5 is proving a pain, so I'm fine bumping to >=3.6.