mintproject / mic

Model Insertion Checker
https://mic-cli.readthedocs.io/en/latest/
5 stars 3 forks source link

MIC fails when the folder has spaces in its name #300

Closed dgarijo closed 3 years ago

dgarijo commented 4 years ago

Describe the bug If I start a mic component from a folder with spaces, I get an error. It looks like there is a problem with the image name

To Reproduce Steps to reproduce the behavior:

  1. mkdir "t t t"
  2. cd '.\t t t\'
  3. mic pkg start

Stacktrace:

(mic_env) PS C:\Users\dgarijo\Desktop\192\ttt\t t t> mic pkg start
WARNING: You are using mic version 1.3.2, however version 1.3.3 is available.
You should consider upgrading via the 'pip install --upgrade mic' command.
Model component name: banana
The directory mic already exists. If you continue, you can lose a previous component
Do you want to continue? [Y/n]: Y
MIC has initialized the component.
[Created] data:      C:\Users\dgarijo\Desktop\192\ttt\t t t\mic\data
[Created] docker:    C:\Users\dgarijo\Desktop\192\ttt\t t t\mic\docker
[Created] src:       C:\Users\dgarijo\Desktop\192\ttt\t t t\mic\src
[Created] mic.yaml:  C:\Users\dgarijo\Desktop\192\ttt\t t t\mic\mic.yaml
C:\Users\dgarijo\Desktop\192\ttt\t t t\mic\mic.yaml created
latest: Pulling from mintproject/generic
Digest: sha256:d99d739ed5cd06adb7584733fcb24be2907c488adc8ec913a3653a9a985c2580
Status: Image is up to date for mintproject/generic:latest
docker.io/mintproject/generic:latest
Downloading the base image and building your image
Step 1/6 : FROM mintproject/generic:latest

 ---> c6a09cfc38e3
Step 2/6 : COPY entrypoint.sh /set_umask.sh

 ---> 2c0f307c5570
Step 3/6 : RUN echo "Converting line endings"

 ---> Running in 580c485fd6e7
Converting line endings
 ---> ea9ae6d88d33
Step 4/6 : RUN sed -i 's/\r//' set_umask.sh

 ---> Running in cff226603ead
 ---> d91ca041c361
Step 5/6 : RUN chmod +x /set_umask.sh

 ---> Running in ea8d35dfa0a2
 ---> 1fbbb49d9657
Step 6/6 : ENTRYPOINT ["/set_umask.sh"]

 ---> Running in d73e8154e170
 ---> 33764398c25f
Successfully built 33764398c25f
Successfully tagged banana:latest

        You are in a Linux environment Debian distribution.
        You can use `apt` to install new packages
        For example:
        $ apt install r-base

Unable to find image 't:latest' locally
docker: Error response from daemon: pull access denied for t, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.
See 'docker run --help'.
issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.95. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Cmheidelberg commented 4 years ago

Fixed: pending pr #297