minvws / nl-covid19-coronacheck-app-android

European Union Public License 1.2
44 stars 28 forks source link

'Ziekteverwekker / Disease' text value in details international QR-code wrong #54

Closed KTMAdventureRider closed 3 years ago

KTMAdventureRider commented 3 years ago

Describe the bug, issue or concern

When I choose Main screen - Internationaal - select Button BEKIJK QR) and then select the question mark at the top right in the international QR code screen (the screen with the QR code and the animations), the text value at the label 'Ziekteverwekker / Disease targeted:' is not correct. The text value states 'Ziekteverwekker:' Comparing this with the paper version (papieren bewijs), generated through https://coronacheck.nl/nl/print/ I noticed the difference. There the text value states 'COVID-19', which is correct, I assume.

To Reproduce

Steps to reproduce the behavior:

  1. Go to main screen 'Mijn bewijzen'
  2. Select menu 'Internationaal'
  3. Click on button 'BEKIJK QR'
  4. Click on question mark symbol in right top corner
  5. See error under 'Ziekteverwekker / Disease targeted:' where the text value states 'Ziekteverwekker:'

Expected behavior

The expected behavior should be that the text value should display 'COVID-19' instead of 'Ziekteverwekker:'

Screenshots

coronacheckapp_bug

Smartphone (please complete the following information):

Governance

jpelgrom commented 3 years ago

This seems to be a case of simply using the wrong string, I'll submit a PR to fix this shortly.

ijansch commented 3 years ago

This was fixed, thanks again!