miraclx / freyr-js

A tool for downloading songs from music streaming services like Spotify and Apple Music.
https://git.io/freyr-js
Apache License 2.0
1.61k stars 103 forks source link

Add support for Tidal #33

Open MoroseCorpse opened 3 years ago

MoroseCorpse commented 3 years ago

I have a suggestion that you could add. It would be very nice if your tool would also support the streaming service Tidal, as this is also used by a lot of people

miraclx commented 3 years ago

Great idea, I've just recently discovered https://github.com/yaronzz/Tidal-Media-Downloader which might be a good alternative for now. Although freyr could certainly extend itself to support tidal.

Currently, the best API interface to tidal that I've seen so far is https://github.com/tamland/python-tidal which is in python.

So, freyr would need to complete #21 for it to support this. Just like in #6.

However, that library directly requires users to provide private credentials like their username and password which, I can assume, some users might not be comfortable with.

This should "preferrably" be an oauth2 login.

So, until https://github.com/tehkillerbee/mopidy-tidal/pull/27 is merged into python-tidal (as suggested here https://github.com/tehkillerbee/mopidy-tidal/pull/27#issuecomment-743202274), freyr would hold back supporting this

miraclx commented 3 years ago

Another thing to note is freyr doesn't currently support downloading feeds from non-youtube sources, although technically, it's modular enough to easily support it. But the postprocessor isn't configured to output anything other than m4a.

Would gladly welcome any PRs to work on this.