Make version check compatible with new major versions

mirage / bigarray-compat

Expose Stdlib.Bigarray when possible but try not to break stuff

ISC License

5 stars 7 forks source link

Closed emillon closed 5 years ago

emillon commented 5 years ago

Hi!

The previous version would check if both are greater, so 5.0 would be considered lower. It can be fixed by using lexicographic comparison.

(if this piece of code was copied from another project in might be interesting to know if it needs fixing over there as well)

TheLortex commented 5 years ago

I took a look and the original code already do lexicographic comparisons, my bad. Thank you for the PR !

kit-ty-kate commented 2 years ago

Could this be released? This is causing bugs for people trying to test OCaml 5.00

TheLortex commented 2 years ago

I'm on it!