search

mirage / mirage-crypto

Cryptographic primitives for OCaml, in OCaml (also used in MirageOS)
ISC License
77 stars 43 forks source link

Mingw friendly case for includes. #248

Open mefyl opened 1 month ago

mefyl commented 1 month ago

Since windows filesystem is case insensitive and, AFAIK, windows.h is always lowercase in MinGW distributions, using a lowercase include will work on both transparently.

Currently:

mc_getrandom_stubs.c:60:10: fatal error: Windows.h: No such file or directory
   60 | #include <Windows.h>
      |          ^~~~~~~~~~~
hannesm commented 1 month ago

Thanks for your PR. By chance, would you be able to add a GitHub action (or another CI) that tests the "mingw" case?

mefyl commented 1 month ago

I'm not really familiar with Github actions; is there already a CI environment cross compiling with mingw ?

hannesm commented 1 month ago

I'm not really familiar with Github actions; is there already a CI environment cross compiling with mingw ?

I don't know. Maybe ask the people who're into "windows" and "OCaml" - they must have some secret runes how to test their projects in CI / GitHub actions.