search

mirage / ocaml-cohttp

An OCaml library for HTTP clients and servers using Lwt or Async
Other
713 stars 175 forks source link

cohttp-eio: Use system authenticator in example #1091

Closed talex5 closed 1 month ago

talex5 commented 2 months ago

It turns out that using a proper authenticator is quite easy, so I've updated the example to use that. Otherwise, people are likely to copy the null authenticator code (despite the warning in the comment).

rgrinberg commented 1 month ago

Who is responsible for merging the cohttp-eio PR's?

talex5 commented 1 month ago

I can merge it myself, but I like to wait for a review if possible (thanks @MisterDA!).