search

mirakl / sdk-php-shop

Mirakl PHP SDK for sellers
29 stars 16 forks source link

fix phpunit compatibility #44

Closed RocKordier closed 1 year ago

RocKordier commented 1 year ago

Hey,

at the moment its not possible to resolve dev - dependencies of the package.

PHPUnit:~9.0 is only compatible with PHP 7.3 and above. Using PHPUnit 8 is not recommended because it has reached EOL.

Are there any plans to cover the package with unit tests in general?

IMHO the PHP dependency should also be raised to a supported version (8.1 or 8.2)

Let me know if I should raise the dependency any higher.

Thx Eric

jreinke commented 1 year ago

Hello,

Thanks for your feedback, the v1.18.1 has been released and fixes the problem. We had to downgrade to PHPUnit 8.x because we still need to support older PHP versions.