search

mirleft / ocaml-x509

X509 (RFC5280) handling in OCaml
BSD 2-Clause "Simplified" License
52 stars 34 forks source link

CRL: move [crls] argument in CRL.is_revoked to the last position #144

Closed hannesm closed 3 years ago

hannesm commented 3 years ago

This is to avoid warning 16 (defaults to be enabled with 4.12).

hannesm commented 3 years ago

hmm, the "lint-opam" fails with (//cc @talex5):

x509.opam: changes needed:
  "mirage-crypto-pk"                       [from lib] (remove {with-test})

The opam file contains:

  "mirage-crypto-pk"
  "mirage-crypto-pk" {with-test & >= "0.8.10"}

This is wrong -- the opam file has twice a mirage-crypto-pk dependency: for normal operations, any release is fine. To succeed the test suite, any version greater or equal 0.8.10 is needed. Is there a cleaner way to express this (//cc @kit-ty-kate who may have an answer)? Or could "lint-opam" be adapted to cope with such dependencies in an opam file?

kit-ty-kate commented 3 years ago

Yes I've reported this issue in opam-dune-lint a few weeks ago: https://github.com/ocurrent/opam-dune-lint/issues/23 I'll have a look now if I can fix this issue myself quickly.

kit-ty-kate commented 3 years ago

https://github.com/ocurrent/opam-dune-lint/pull/25 should fix that. I don't have commit rights on this repository but I'll ask around.

talex5 commented 3 years ago

I've merged the fix now.

hannesm commented 3 years ago

Thanks @talex5 @kit-ty-kate