search

miroesli / psscscs

Reinforcement Learning Battlesnake
MIT License
2 stars 1 forks source link

Yang #2

Closed Fool-Yang closed 4 years ago

Fool-Yang commented 4 years ago

it's snaking

miroesli commented 4 years ago

I'd recommend naming the file something more informative so that we can see what type of model it is without looking at the code.

miroesli commented 4 years ago

I'm also hesitant with having the main.py as a place where we test models as I think we should keep that for what we will consider to be our MVP. Here are my suggestions:

  1. Maybe make a copy of it and name is as your model within the app folder
  2. create a folder called models under the root directory where you will put things such as the TEMP.py file. - This will be where we all put our own models we would like to test

Thoughts @Krocodial @Swapnil-dx @AhmedNSidd @Fool-Yang ?

Swapnil-dx commented 4 years ago

Yup I think that's a good idea!

Fool-Yang commented 4 years ago

I'm also hesitant with having the main.py as a place where we test models as I think we should keep that for what we will consider to be our MVP. Here are my suggestions:

  1. Maybe make a copy of it and name is as your model within the app folder
  2. create a folder called models under the root directory where you will put things such as the TEMP.py file. - This will be where we all put our own models we would like to test

Thoughts @Krocodial @Swapnil-dx @AhmedNSidd @Fool-Yang ?

That's not easy to do with python. I have to import from a parent directory, which involves a thing called relative import and it gets tricky. I changed the file name and created a new file, so the main.py will be the original one. The best (easiest) solution is to have folders in the app folder, so we can import from there. I will do that for now, and if you really want to put the folders in the root dir then you should give it a try and see if you can get it working https://stackoverflow.com/questions/14132789/relative-imports-for-the-billionth-time/14132912#14132912

Fool-Yang commented 4 years ago

  1. a bat script is added to the root dir along with the game engine. If you uses windows, then double click the .bat file will run my snake locally and open the browser.

  2. two new folders added in the app folder. algorithms and models

  3. TEMP.py renamed to preprocess and is now in the algorithms folder