mirromutth
commented
4 years ago Hi there,
Thanks for the report.
I tried, but have not reproduce this. Did you use createBatch for insert records, or createStatement with multiple bindings for insert, or just Repository.saveAll? They are different, so I maybe need to know what happened.
One more thing, the ConnectionPool is also a ConnectionFactory, and the pool seems like be created on pooling ConnectionFactory (see line .option(DRIVER, "pool") in method connectionFactory()).
So I suggest the code should be rewritten to something like:
@Slf4j
@Configuration
@RequiredArgsConstructor
@EnableTransactionManagement(proxyTargetClass = true)
public class DataConfig extends AbstractR2dbcConfiguration {
@Override
@Bean
public ConnectionFactory connectionFactory() {
ConnectionFactory connectionFactory = ConnectionFactories.get(ConnectionFactoryOptions.builder()
.option(DRIVER, "mysql") // should not be "pool"
.option(SSL, true)
.option(HOST, "127.0.0.1")
.option(PORT, 3306)
.option(USER, "me")
.option(PASSWORD, "pass")
.option(DATABASE, "db")
.option(CONNECT_TIMEOUT, ofSeconds(20))
.build()); // no MAX_SIZE because it should be configured by following
ConnectionPoolConfiguration configuration = ConnectionPoolConfiguration
.builder(connectionFactory)
.maxAcquireTime(ofSeconds(5))
.maxCreateConnectionTime(ofSeconds(5))
.maxIdleTime(ofSeconds(1))
.maxLifeTime(ofSeconds(2))
.maxSize(101)
.build();
return new ConnectionPool(configuration);
}
...
}
olexandra-dmytrenko
BBream
Steps to reproduce: 1) Upload large amount (4700) records to a table 2) Try to upload the same records for the second time 3) Receive duplicate entry exception 4) Leave table in the same state or erase or all the records. 5) Upload same records another time *)
Expected: Depending on the step 4 either receive Duplicate entry exception or successfully uploaded records
Actual: Timeout exception for getting access to the DB from all the services including HeidiSQL. The DB starts working again only when Docker that ran it is stopped and then started
*) Tried also uploading smaller amount of data, e.g. 1200 records, and doing the same steps with it. I've successfully received Duplicate exception several times in a row, but then the application hangs without writing anything to log and never finishing request:
Settings: Versions in Java: private val SpringBootVersion = "2.2.1.RELEASE" private val r2dbcVersion = "0.8.0.RC2" springDataR2dbcVersion = "1.0.0.RC1" private val projectReactor = "3.3.0.RELEASE" val springDatar2dbc = "org.springframework.data" % "spring-data-r2dbc" % springDataR2dbcVersion val r2dbc = "io.r2dbc" % "r2dbc-spi" % r2dbcVersion val r2dbcMySql = "dev.miku" % "r2dbc-mysql" % "0.8.0.RC2" val r2dbcPool = "io.r2dbc" % "r2dbc-pool" % "0.8.0.RC2" val reactorAddons = "io.projectreactor.addons" % "reactor-extra" % projectReactor
Docker MySQL Settings services: mysql: hostname: mysql image: mysql:5.7.23 command: --default-authentication-plugin=mysql_native_password ports:
3306:3306
import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration; import org.springframework.core.convert.converter.Converter; import org.springframework.core.env.Environment; import org.springframework.data.r2dbc.config.AbstractR2dbcConfiguration; import org.springframework.data.r2dbc.connectionfactory.R2dbcTransactionManager; import org.springframework.data.r2dbc.support.R2dbcExceptionTranslator; import org.springframework.transaction.ReactiveTransactionManager; import org.springframework.transaction.annotation.EnableTransactionManagement;
import dev.miku.r2dbc.mysql.MySqlConnectionConfiguration; import dev.miku.r2dbc.mysql.constant.ZeroDateOption; import io.r2dbc.pool.ConnectionPool; import io.r2dbc.pool.ConnectionPoolConfiguration; import io.r2dbc.spi.ConnectionFactories; import io.r2dbc.spi.ConnectionFactory; import io.r2dbc.spi.ConnectionFactoryOptions; import lombok.RequiredArgsConstructor; import lombok.extern.slf4j.Slf4j;
import static io.r2dbc.pool.PoolingConnectionFactoryProvider.MAX_SIZE; import static io.r2dbc.spi.ConnectionFactoryOptions.CONNECT_TIMEOUT; import static io.r2dbc.spi.ConnectionFactoryOptions.DATABASE; import static io.r2dbc.spi.ConnectionFactoryOptions.DRIVER; import static io.r2dbc.spi.ConnectionFactoryOptions.HOST; import static io.r2dbc.spi.ConnectionFactoryOptions.PASSWORD; import static io.r2dbc.spi.ConnectionFactoryOptions.PORT; import static io.r2dbc.spi.ConnectionFactoryOptions.PROTOCOL; import static io.r2dbc.spi.ConnectionFactoryOptions.SSL; import static io.r2dbc.spi.ConnectionFactoryOptions.USER; import static java.lang.Boolean.FALSE; import static java.lang.Boolean.TRUE; import static java.time.Duration.ofSeconds;
@Slf4j @Configuration @RequiredArgsConstructor @EnableTransactionManagement(proxyTargetClass = true) public class DataConfig extends AbstractR2dbcConfiguration { @Bean public ConnectionPool connectionPool(ConnectionFactory connectionFactory) { ConnectionPoolConfiguration configuration = ConnectionPoolConfiguration .builder(connectionFactory) .maxAcquireTime(ofSeconds(5)) .maxCreateConnectionTime(ofSeconds(5)) .maxIdleTime(ofSeconds(1)) // was 30 mins .maxLifeTime(ofSeconds(2)) // was 30 seconds .maxSize(101) .build(); ConnectionPool connectionPool = new ConnectionPool(configuration); return connectionPool; }
@Override @Bean public ConnectionFactory connectionFactory() { ConnectionFactory connectionFactory = ConnectionFactories // .get(environment.getProperty("db.url")); .get(ConnectionFactoryOptions.builder() .option(DRIVER, "pool") .option(PROTOCOL, "mysql") // driver identifier, PROTOCOL is delegated as DRIVER by the pool. .option(SSL, true) .option(MAX_SIZE, 101) .option(HOST, "127.0.0.1") .option(PORT, 3306) .option(USER, "me") .option(PASSWORD, "pass") .option(DATABASE, "db") .option(CONNECT_TIMEOUT, ofSeconds(20)) .build()); return connectionPool(connectionFactory); } ... }