search

mirumee / django-prices

Django fields for the prices module
158 stars 53 forks source link

Fixes #71 & non-use of TaxedMoneyField.verbose_name #93

Closed ashishnitinpatil closed 4 years ago

ashishnitinpatil commented 4 years ago

Adds the unique attribute to NonDatabaseFieldBase & fixes non-use of verbose_name kwarg in TaxedMoneyField.

Doing this on behalf of @Zagrebelin since I didn't see any existing PR for the same.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a4fdbd0). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #93   +/-   ##
=========================================
  Coverage          ?   89.68%           
=========================================
  Files             ?        6           
  Lines             ?      126           
  Branches          ?       11           
=========================================
  Hits              ?      113           
  Misses            ?       10           
  Partials          ?        3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4fdbd0...a7d6af3. Read the comment docs.

mistacoda commented 4 years ago

Can you guys merge and release this version? As currently django admin is broken due to this error

patrys commented 4 years ago

I want to release a Django 3-compatible version soon (likely next few days).