search

mirumee / legacy-views

A legacy fork of Saleor that contains the old storefront and dashboard code
Other
14 stars 14 forks source link

Bootstrap rendered form shows fields errors at the top #16

Open ipsingh06 opened 5 years ago

ipsingh06 commented 5 years ago

What I'm trying to achieve

I expected only non-field errors to be displayed at the top.

Steps to reproduce the problem

  1. Go to the Saleor demo: https://demo.getsaleor.com/en/account/login/
  2. Empty the email and password fields and click 'Log In'

What I expected to happen

Only non-field errors to show at the top (in this case, nothing)

There's already a fix for this in place in saleor.core.utils.form_renderer.FormRenderer. However, it is not kicking in because the bootstrap settings are misnamed. The fix is to rename the following in settings.py: bootstrap4 -> BOOTSTRAP4