Remote pinned posts are dropped if any of them are followers-only

[LimePotato]

💡 Summary

Originally thought this was an iceshrimp.net issue (seen here). (this is also a duplicate of this iceshrimp issue as this is misskey.)

as described in that issue, if a remote user has a pinned post that is followers only, all pins from that user will be dropped.

Example being this note

🥰 Expected Behavior

Regardless of note visibility, all pinned posts should be accepted.

🤬 Actual Behavior

If a followers-only post is pinned on the remote, all pinned posts are discarded.

📝 Steps to Reproduce

1. Make and pin a followers only post
2. Make and pin an unlisted/public post
3. On a misskey instance, update the remote user information, and look for pinned posts

💻 Frontend Environment

No response

🛰 Backend Environment (for server admin)

No response

Do you want to address this bug yourself?

• [ ] Yes, I will patch the bug myself and send a pull request

[kakkokari-gtyih]

Iceshrimp (JS) is a fork based on Misskey v12, which is very old. Therefore, this might not be seen in today's Misskey as it might already fixed after Calckey forked.

Have you tried to see if this still occurs with the latest or near-latest version of Misskey (v2024.x.x)?

[LimePotato]

this occurs on sharkey, a soft fork of current misskey. so i can confirm this is not just a M12 issue.

[KisaragiEffective]

It would be required to check if this can be reproducible on original Misskey w/o any forks or patches.

[LimePotato]

i provide a link to a post and account (@nelle@limbo.town) which is reproducing the bug, i wont be making a misskey account but it should be easy to fetch the post and account within a few seconds with the information provided.