mitchelloharawild / vitae

R Markdown Résumés and CVs
https://pkg.mitchelloharawild.com/vitae/
1.22k stars 237 forks source link

Formating for oldstyle theme has overlap between list items and contact yaml items (phone, web, git, email, etc..) #189

Open rennerom opened 2 years ago

rennerom commented 2 years ago

List item's left margins look like they are unintentionally too far to the left, and overlap with some yaml contact data output (phone, email, git, etc...). This looks to be the case for oldstyle and fancy themes.

Definitely not an issue when dumping in detailed or brief entries, but the default template provided when creating a new moderncv highlighted a few of these formatting complications while I experimented with the theming.

---
name: Marie
surname: Curie
position: "Professor"
address: "School of Physics & Chemistry, École Normale Supérieure"
phone: +1 22 3333 4444
www: mariecurie.com
email: "Marie.Curie@ens.fr"
twitter: mariecurie
github: mariecurie
linkedin: mariecurie
date: "`r format(Sys.time(), '%B %Y')`"
output: 
  vitae::moderncv:
    theme: oldstyle
---

```{r setup, include=FALSE}
knitr::opts_chunk$set(echo = FALSE, warning = FALSE, message = FALSE)
library(vitae)

Some stuff about me

Test section

screenshot 2021-12-02 at 9 54 46 PM screenshot 2021-12-02 at 9 58 47 PM
rennerom commented 2 years ago

woops, I realize this theme is maintained by zdanaux. Should this issue be opened on their moderncv repo instead of the vitae repo?

mitchelloharawild commented 2 years ago

It would be nice if it could be fixed upstream, but I'm worried you won't get much help there.

With your rmd provided above, I can't reproduce the issue - this is what I get: image

rennerom commented 2 years ago

woah, I really let time get away from me there. Sorry for the late reply!

I think we're running different moderncv themes?

I can replicate your styling exactly when I set the output in my yaml header to

output: 
  vitae::moderncv:
    theme: casual

but when I use

output: 
  vitae::moderncv:
    theme: oldstyle

or

output: 
  vitae::moderncv:
    theme: fancy

that's when I get the overlap.