Report issues with check-runs instead of only comments, and remove comments that are resolved

[mattisdada]

Unfortunately this became a slightly bigger PR than expected, but this adds two majors pieces of functionality:

• Be able to switch the mode of reporting from comments (current) and to check runs
  • What is check runs? It is the built in mechanism in GitHub pull requests to add annotations from scanning tools (ie, linters). In my opinion it works a bit better than comments as it doesn't produce notifications, they are softer and show as a status on the PR
• Remove resolved comments from the PR
  • Unfortunately, the REST API cannot be used to resolve comments, that can only be done via the GraphQL mutations API but it doesn't have cross compatible IDs
  • Added in a prefix to each comment so they can be safely deleted - not the most reliable method

Structurally, all of the functionality for generating comments and check-runs have been moved to their own files.

Happy to break up this PR if needed

Check run preview

To test, you can use the following action:

    - name: SFDX Scanner
      uses: mattisdada/sfdx-scan-pull-request@main
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      with:
        report-mode: check-runs # or swap to `comments` to toggle between them

[matthew-gladman-oua]

There was a big TS conversion this morning, I'll rewrite this in TS along with the other changes, it should be a pretty organic fit

[mitchspano]

Thank you for your contributions @matthew-gladman-oua! Apologies for the TS conversion introducing merge conflicts on this change - James, Jonathan and I were working on that for a long time and wanted to get that in before introducing new changes.

[matthew-gladman-oua]

Thank you for your contributions @matthew-gladman-oua! Apologies for the TS conversion introducing merge conflicts on this change - James, Jonathan and I were working on that for a long time and wanted to get that in before introducing new changes.

All good :) TS conversion will be much better long term, it won't take too long to refactor. I had majority of these changes written 1-2 months ago but lost steam to clean it up so it was merge ready, so mostly my fault 😅

Any feedback on the conceptual changes (ie, using check-runs, making it the default, deleting comments, etc) would be great

[mattisdada]

Started the port, mostly done, but not fully tested yet:

• https://github.com/mattisdada/sfdx-scan-pull-request/tree/ts-port

I did notice the number of lines scanned were way bigger than it used to be, not sure if that's an issue in the TS conversion or my branch 🤔 But my changes shouldn't have affected the lines scanned, so, not sure

[mattisdada]

Replaced with new PR #40