mithilesh1125 / tesseract-ocr

Automatically exported from code.google.com/p/tesseract-ocr
Other
0 stars 0 forks source link

strngs.h has unnecessary include of genericvector.h #635

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Attached is a diff for ccutil\strngs.h

It just removes the #include of genericvector.h (which is already included in 
strngs.cpp) and replaces it with a forward declaration of GenericVector.

   template <typename T> class GenericVector;

I have to assume this is wanted, since otherwise the changes to api\baseapi.h 
make no sense. Those recent changes would indicate that we are trying *NOT* to 
force inclusion of genericvector.h when only baseapi.h & strngs.h are included.

With the lastest trunk revision r679, I've rebuilt libtesseract, tesseract, and 
all the training apps with this change and everything still builds fine. I'm on 
Windows 7 64-bit, Visual Studio 2008, and using my VS2008 Solution, but I don't 
believe this change is platform specific.

The # of "public" header files required is now down to the following 13:

   api\apitypes.h
   api\baseapi.h
   ccmain\thresholder.h
   ccstruct\publictypes.h
   ccutil\errcode.h
   ccutil\fileerr.h
   ccutil\host.h
   ccutil\memry.h
   ccutil\platform.h
   ccutil\serialis.h
   ccutil\strngs.h
   ccutil\tesscallback.h
   ccutil\unichar.h

Original issue reported on code.google.com by tomp2...@gmail.com on 23 Feb 2012 at 3:54

Attachments:

GoogleCodeExporter commented 9 years ago
fixed in r682

Original comment by zde...@gmail.com on 26 Feb 2012 at 4:39