mithril-security / blindai

Confidential AI deployment with secure enclaves :lock:
https://www.mithrilsecurity.io/
Apache License 2.0
500 stars 35 forks source link

Multiple model inputs for BlindAi #75

Closed kbamponsem closed 2 years ago

kbamponsem commented 2 years ago

Description

Implementation of multiple model inputs. This request contains updates on both the server and client.

Now data_inputs can either but a List or List[List], depending on whether the model is a multiple input model.

client.run_model(data_inputs, sign=True)



## Related Issue

This project accepts pull requests related to open issues. If suggesting a new feature or change, please discuss it in an issue first.
If fixing a bug, there should be an issue describing it with steps to reproduce.
Please link to the issue here.

## Type of change
The types of changes must be deduced from the labels of the related issues. Please consider providing these further details.

- [x] This change requires a documentation update
- [x] This change affects the client
- [x] This change affects the server
- [x] This change affects the API
- [ ] This change only concerns the documentation

## How Has This Been Tested?

It has only been tested with integration, but not with unit tests. Need to update the unit tests directory with the latest from the `master` branch.

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] My changes generate no new warnings
- [ ] I have updated the documentation according to my changes

<!--- To add when we set tests-->
<!-- 
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
-- >
JoFrost commented 2 years ago

Thanks for your recent changes! I will do some tests on my side. Let's get this merged asap :)

kbamponsem commented 2 years ago

Thanks for your recent changes! I will do some tests on my side. Let's get this merged asap :)

Alright. Noted!

github-actions[bot] commented 2 years ago

☂️ Python Cov

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
392 347 89% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
client/blindai/client.py 91% 🟢
TOTAL 91% 🟢

updated for commit: 225aab6 by action🐍