mitodl / micromasters

Portal for learners and course teams to access MITx Micromasters® programs
https://mm.mit.edu
BSD 3-Clause "New" or "Revised" License
29 stars 17 forks source link

Return final grade in API for financial aid-enabled courses #1078

Closed pdpinch closed 7 years ago

pdpinch commented 7 years ago

MicroMasters programs with financial aid won't use certificates, so we can't rely on the certificates API to get the user's final grade or to determine the user's passed status.

For those programs we can determine the "final" grade and passed/not-passed status by making a call to the course_grade API after the course end_date.

For example, using my user, a call to https://courses.edx.org/api/grades/v0/course_grade/HarvardX/SW12.3x/1T2014/users/?username=pdpinch returns:

[
    {
        "username": "pdpinch",
        "letter_grade": "Pass",
        "percent": 0.97,
        "course_key": "HarvardX/SW12.3x/1T2014",
        "passed": true
    }
]
Ferdi commented 7 years ago

This will be only for DEDP case right. The rest will still use certs ?

pdpinch commented 7 years ago

I was thinking it would be easier if we used the same mechanism for all courses, but if you prefer to use the certificates table that's fine with me.

The final grade in the certificate table is more stable, and less expensive to query.

gsidebo commented 7 years ago

A more appropriate title for this would probably be "Return final grade in API for financial aid-enabled courses". How we get that final grade is an implementation detail. There's no reason for us to ditch certificate grades for non-financial aid courses

Ferdi commented 7 years ago

@gsidebo updated title and description

pdpinch commented 7 years ago

@ferdi I don't think the title change stuck. Can we discuss this briefly in planning on Monday?

pdpinch commented 7 years ago

I spoke with Giovanni and confirmed that we won't "ditch certificate grades for non-financial aid courses" as @gsidebo put it.