mitre-attack / attack-navigator

Web app that provides basic navigation and annotation of ATT&CK matrices
https://mitre-attack.github.io/attack-navigator
Apache License 2.0
2.01k stars 593 forks source link

Reverse Tabnabbing #527

Closed superuser5 closed 1 year ago

superuser5 commented 1 year ago

There is small security bug "Reverse Tabnabbing" in the https://github.com/mitre-attack/attack-navigator/blob/master/nav-app/src/app/layer-upgrade/layer-upgrade.component.html

from OWASP: Reverse tabnabbing is an attack where a page linked from the target page is able to rewrite that page, for example to replace it with a phishing site. As the user was originally on the correct page they are less likely to notice that it has been changed to a phishing site, especially if the site looks the same as the target. If the user authenticates to this new page then their credentials (or other sensitive data) are sent to the phishing site rather than the legitimate one. Ref: https://owasp.org/www-community/attacks/Reverse_Tabnabbing

To fix it:

https://github.com/mitre-attack/attack-navigator/blob/master/nav-app/src/app/layer-upgrade/layer-upgrade.component.html#L17 modify

                <a href="https://attack.mitre.org/resources/versions/" target="_blank">

to

                <a href="https://attack.mitre.org/resources/versions/" target="_blank"  rel="noopener noreferrer">