search

mity / md4c

C Markdown parser. Fast. SAX-like interface. Compliant to CommonMark specification.
MIT License
776 stars 146 forks source link

use typedef structs that are compatible with both c and c++ #18

Closed aoloe closed 7 years ago

aoloe commented 7 years ago

the current forward declarations do not work with g++.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 86.192% when pulling 46dce4b3593b12061aef421fd20e6975bcc12a14 on aoloe:typdef-enum into aeaff18e871b13b3781267413eaea0cd3cdff108 on mity:master.

mity commented 7 years ago

Thanks.

The diff itself is ok.

But I noticed the commit belongs to author a.l.e which github does not recognize as belonging to your account. It's not a problem for me, but maybe you might like to fix it before I merge it? If it's not important for you, just let me know and I'll merge as it is.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 86.192% when pulling 35d33a289ef438bb38cf35bc55734b74d1ae2246 on aoloe:typdef-enum into aeaff18e871b13b3781267413eaea0cd3cdff108 on mity:master.

aoloe commented 7 years ago

well, the link was not that important... but i took it as a challenge and a/ fixed the gitconfig on this computer b/ discovered how to change the name attached to the last commit!

anyway: thanks for your work on md4c! i could get a very basic c++ sample that correctly binds the callbacks. during the next few days, i'll try to make it more c++-alike and -- if you welcome it -- i'll share the samples so that you eventually can use them for the documentation.

mity commented 7 years ago

;-) Again the e-mail is not recognized.

If you want to fix it, you have either to set to your git config e-mail address already registered with your github account, or alternatively you may add more e-mails in your github account settings. See https://github.com/settings/emails.

aoloe commented 7 years ago

oufh... so much work on a sunday night...

i've now added the other address to github : - ) thanks for the instructions!

mity commented 7 years ago

Thanks.