mixxxdj / manual

The Mixxx Manual
https://manual.mixxx.org/
52 stars 119 forks source link

Update djing_with_mixxx.rst - autodj decks orientation #680

Closed Eve00000 closed 4 months ago

Eve00000 commented 5 months ago

Update djing_with_mixxx.rst - autodj decks orientation

Preview: https://deploy-preview-680--mixxx-manual.netlify.app/chapters/djing_with_mixxx#auto-dj

Eve00000 commented 5 months ago

No problem, it's a kind of personal evolution. Before I was told I gave to little information, that there is more then headlines/keynotes to understand something, but my mind was hopping to fast for others to follow my logical reasoning. So I obliged myself giving a circumstantial detailed description of logical steps. It's funny that you're writing the contrary now, that there's to much info. You are experienced in explaining Mixxx (in another style) to users and that's the most important: Mixxx-ers understanding Mixxx.

ronso0 commented 5 months ago

Well, depends on the context ; )

My primary intention was to break that huge text block as many people (me included) are scared by such things. image vs image

ronso0 commented 5 months ago

Are you motivated to update the screenshot, too?

ronso0 commented 5 months ago

I think we should move the new text below the existing paragraph

Auto DJ does not take into account the volume of each track, nor the frequency content, ...

so the crossafder explanation is continuation of that.

What do you think?

Eve00000 commented 5 months ago

Are you motivated to update the screenshot, too?

I think you already know my motivation:-) Scared of big texts? I don't scare easily (except spiders) Yes, that looks more logic What about the 'broken-links-error' ?

Eve00000 commented 5 months ago

I added a screenshot, if you like it we can remove the old one. The txt order has been changed for logical order. WDYT? (I'm statying with abbreviations too)

ronso0 commented 5 months ago

What about the 'broken-links-error' ?

ignore... they are not related to the changes of this PR.

Thanks for the screenshot, but we don't the illustration (it's not translatable), just a simple view of the Auto DJ pane is sufficient. Can you revert to the clean view? Also, please replace the old image file, we don't need it. The new image can be prefixed with the current Mixxx version, so it would be _[source/static/Mixxx-241-Library-Auto-DJ.png).

The txt order has been changed for logical order.

Thank you, this looks good now IMO!

Eve00000 commented 5 months ago

I guess you mean: no writing on the image? I will change the image to the clean printscreen.. When it was too late I thought I should have written numbers that could be explained in the text. OK; that's the logic in the image name. I was keen on doing this pr to learn how to make the manual, there are a lot of missing links in the manual that need some explaining (on a cold and rainy day). I will try to do that tonight (after we defeated the Ukranian team)

ronso0 commented 4 months ago

I guess you mean: no writing on the image? I will change the image to the clean printscreen..

Yes & no, I meant the clean screenshot (no annotations) of only the AutoDJ pane (no decks, no mixer).

Eve00000 commented 4 months ago

ronso, do I have to do something more?

ronso0 commented 4 months ago

This looks good now, thank you. I'll take another look in a few days, and until another @mixxxdj/developers may check if we missed something, or can remove something.

ronso0 commented 4 months ago

I guess you mean: no writing on the image? I will change the image to the clean printscreen..

Yes & no, I meant the clean screenshot (no annotations) of only the AutoDJ pane (no decks, no mixer).

Could you please crop the screenshot accordingly? Then this is ready for merge.

Eve00000 commented 4 months ago

done

ronso0 commented 4 months ago

Uaah, not sure what happened. I ammended a commit updating the context menu image, and squashed all commits into one. Then force-pushed to your branch.

ronso0 commented 4 months ago

Hm, I think the issue is that your branch is named like a remote branch (2.4) and not something like autodj-update.

Could you please try to open a PR from your 2.4 branch? If that doesn't work, I'll revert force-revert your branch to https://github.com/mixxxdj/manual/commit/f174501f1628200275cd125013598bb09117e922 and probably open a new one (or push the squashed commit directly to the mixxx repo).

Sorry for the inconvenience!

Eve00000 commented 4 months ago

Hi ronso, is there a spell of the hithubghosts involved? :-) I gave you acces to my repository because I don't clearly understand what you mean.

ronso0 commented 4 months ago

I'll try to explain: "Maintainers are allowed to edit this pull request." is checked for this PR, so I ammended a commit updating the context menu image, and squashed all commits into one. Then force-pushed to your branch. Then I'd would have merged this PR. But that wasn't possible because my push made Github auto-close this PR, and I can't re-open it. I suspect the reason is that your branch is named like a upstream branch (2.4) and not something like "autodj-update". Not sure though because I never experienced something like this. but please try to stick to this pattern from now on. edit: no, something went wrong with the rebase even though I just squashed (fixup) all commits.

I'll simply push the all-in-one commit to mixxxdj/manual. https://github.com/mixxxdj/manual/commit/e9a5fb65e30766428f37f980fb34492875fbb113

Eve00000 commented 4 months ago

All good ronso0, I trust you completely. Sorry if I did something wrong with the naming.