improve usability of White Noise effect

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.

http://mixxx.org

Other

4.39k stars 1.26k forks source link

improve usability of White Noise effect #11868

Open ronso0 opened 1 year ago

ronso0 commented 1 year ago

Bug Description

The White Noise effect is currently the only Mixxx effect that is a signal generator, not a modulator and the handling feels kind of unintuitive:

effects are applied post-fader, hence White Noise can only be regulated with the Dry/Wet knob
it's activated only if a track is loaded to affected players

It would be nice if it was possible to create White Noise -> Echo effects with the Volume fader like in this example JAMES HYPE "NOISE" SECRET TRICK using Pioneer DDJ-400

https://mixxx.discourse.group/t/white-noise-effect-in-2-4/27891

Version

No response

OS

No response

vespadj commented 4 months ago

We could insert a "Gain" knob, to limit the maximum value. Even better if the signal was multiplied by the value of the channel slider (can this be done?).

We should insert a control that below a certain threshold, the function returns to silence, because by turning the controller, in the zero position, a slight noise is heard (0 --> 0.00xxx some digits --> residual noise). Notes: 1.0 / 127 = 0.007874 if (x < 0.0078) { return silence}

daschuer commented 4 months ago

Hi @vespadj this looks like a ideal first contribution, even without a deep C++ knowledge. Do you have interest to pick this up. On which OS are you. Will you be able to build Mixxx from source? Do you need help? https://github.com/mixxxdj/mixxx/wiki/Bugfix-Workflow

vespadj commented 4 months ago

Hi @daschuer, in https://github.com/mixxxdj/mixxx/pull/2921 I ask to developers to look this thread. For some suggestions from creators.

I tried to create an effect, https://mixxx.discourse.group/t/fx-reverbed-fade/29397/9, but C++ is very hard for me, heavy experience without satisfaction nor results :-| :-)