search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.24k stars 1.24k forks source link

cue point is reset when pressing cue #13350

Open dogo77 opened 2 weeks ago

dogo77 commented 2 weeks ago

Bug Description

i encountered a new issue with cue-mode set to mixxx mode with Roland 505.

[expected] · a cue point is set at the beginning of the song · press PLAY to start the song · press CUE to jump back to the cue point · repeat ad libitum

[experienced behaviour] · a cue point is set at the beginning of the song · press PLAY to start the song · press CUE to jump back to the cue point · now this happens, but the cue point is set to the point when CUE was pressed · press PLAY to start the song · press CUE -> jumps to the new set, but wrong CUE point

[additional info] · i experienced this strange behaviour last night at a gig, i think i did everything as always · happens on both decks, so at this time i don't think it's a faulty hardware button

ty

Version

2.4.1

OS

Archlinux

acolombier commented 2 weeks ago

Which cue mode do you use?

Looking at the code, the CO is never reset, this could be causing an issue.

Sadly I don't own this device. Are you comfortable with JavaScript and Mixxx mapping? Also, are you able to reproduce this issue or was that a one-off?

Swiftb0y commented 2 weeks ago

Looking at the code, the CO is never reset, this could be causing an issue.

That is quoting the sampler code. I don't think that matters here. The CO also doesn't need to be reset, as only the signal is relevant, not the value in this case.

Swiftb0y commented 2 weeks ago

But it would be good to know if the issue can be reproduced without the hardware attached using the onscreen buttons.

dogo77 commented 2 weeks ago

Which cue mode do you use?

cue-mode is set to Mixxx mode (default)

Sadly I don't own this device. Are you comfortable with JavaScript and Mixxx mapping? Also, are you able to reproduce this issue or was that a one-off?

But it would be good to know if the issue can be reproduced without the hardware attached using the onscreen buttons.

okay, i tried multiple variations, here are my findings:

  1. Controller activated (Options -> Preferences -> Controllers)
  1. Controller DEactivated (Options -> Preferences -> Controllers)
Swiftb0y commented 2 weeks ago

Thats good to know. That isolates the problem to the controller mapping.

press CUE -> jumps to the new set, but wrong CUE point

Can you elaborate on what you mean with wrong Cue point? There is only ever one cue point per track. Do you mean hotcue?

dogo77 commented 2 weeks ago

Thats good to know. That isolates the problem to the controller mapping.

press CUE -> jumps to the new set, but wrong CUE point

Can you elaborate on what you mean with wrong Cue point? There is only ever one cue point per track. Do you mean hotcue?

shure! as i realize that it is very hard to describe that weird behaviour in written form, i hope that screencast gives a clue Bildschirmaufnahme_20240610_220114.webm

I start the song by hitting the PLAY button. At second 9 i hit the CUE button. Jumps back to initial CUE Point but at the same time set's a new (wrong) CUE Point Then i hit PLAY again, let it play beyond that CUE point Then i hit CUE button again: jumps to the previous set, but wrong CUE Point but at the same time set's a new (wrong) CUE Point. repeat ad libitum, always the same behaviour. HTH

Swiftb0y commented 2 weeks ago

thats weird. I don't know what the culprit could be. can you share your log when starting mixxx with --controllerDebug when you reproduce the issue?

dogo77 commented 2 weeks ago

shure. did the same as in the video. mixxx.log

dogo77 commented 2 weeks ago

i dare to mention @Holzhaus at this time as he – if i remember correctly – has the same controller and wrote the mapping. i also dare to mention #13352 as i have a growing suspicion that there might be a connection and the problem i experienced there is also mapping related, but that's just a gut feeling :)